Http Request Cache Part 1 #2434

tewaro · 2024-07-24T17:14:26Z

RM-18292

refs #698 and cloudflare/workers-sdk#2514

Follow-up to reintroduce the behavior that was reverted in #2432

Updates the Request object to support specifying a cache mode per the standard. Only undefined, 'no-store' and 'no-cache' may be specified, and the fetch implementation specifically does not implement the semantics for either 'no-store' or 'no-cache' yet.
Also adds the compatibility flag for cacheHeaderEnabled. This just lays the ground work for the additional changes.

The next step is to start adding the support for adding the appropriate header fields in the fetch implementation behind an autogate

src/workerd/api/http.h

src/workerd/jsg/struct.h

src/workerd/api/http-test.wd-test

src/workerd/jsg/jsg.h

src/workerd/api/http.h

src/workerd/api/http.c++

src/workerd/jsg/README.md

src/workerd/jsg/struct.h

src/workerd/api/http.h

tewaro · 2024-08-06T05:29:31Z

hmm, does the TS override here need to account for the difference in the cache property definition? I can't recall off the top of my head how the jsg::Unimplemented cache; is currently reflected in the generated types.

Based on the results of this PR: #2480 the typescript results are no different. Do we want to add tests for every frontend?

…ttp-request-cache-part1" This reverts commit e7cd9f4, reversing changes made to d1b6269.

…STRUCT

dario-piotrowicz

Looks good to me (from the types generation point of view) 🙂

dario-piotrowicz · 2024-08-19T08:36:29Z

In the non-experimental types files we get this addition:

So, the comment plus the ?: undefined declaration

I think this quite ugly... but maybe acceptable? 🤷

Ideally I think we should not add anything in those files, but I have no idea about the technical limitations and whatnot, if this is the best we can do I think it's fine

dario-piotrowicz

Looks perfect! thanks for the ts improvement @AdityaAtulTewari! 🫶

pure-commerce · 2025-01-07T19:34:03Z

Does Workers support caching within NextJS? Seems like nothing is cached. Even with KV bindings added.

tewaro requested review from a team as code owners July 24, 2024 17:14

tewaro requested review from harrishancock, jp4a50 and kentonv July 24, 2024 17:14

tewaro force-pushed the AdityaAtulTewari/http-request-cache-part1 branch from 905efd7 to 975063b Compare July 24, 2024 17:37

tewaro changed the base branch from main to AdityaAtulTewari/claim-cache-option-enabled-compat-flag July 24, 2024 17:57

Base automatically changed from AdityaAtulTewari/claim-cache-option-enabled-compat-flag to main July 24, 2024 18:16

kentonv reviewed Jul 24, 2024

View reviewed changes

src/workerd/api/http.h Show resolved Hide resolved

tewaro force-pushed the AdityaAtulTewari/http-request-cache-part1 branch from 3afdcc0 to 0a12f2c Compare July 26, 2024 19:04

tewaro requested a review from kentonv July 29, 2024 15:10

kentonv reviewed Jul 29, 2024

View reviewed changes

src/workerd/jsg/struct.h Outdated Show resolved Hide resolved

src/workerd/api/http-test.wd-test Outdated Show resolved Hide resolved

src/workerd/api/http-test.wd-test Outdated Show resolved Hide resolved

tewaro force-pushed the AdityaAtulTewari/http-request-cache-part1 branch from 0a12f2c to fff5de3 Compare July 29, 2024 17:17

tewaro requested a review from kentonv July 29, 2024 17:34