Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively freeze JSON bindings/modules #2415

Open
isker opened this issue Jul 19, 2024 · 0 comments
Open

Recursively freeze JSON bindings/modules #2415

isker opened this issue Jul 19, 2024 · 0 comments

Comments

@isker
Copy link
Contributor

isker commented Jul 19, 2024

workerd should recursivelyFreeze JSON data parsed directly from its config. In my mind, these values are application-wide configuration, the mutation of which when handling a request has the potential to result in subtle but serious bugs. It may not be obvious to developers in shared codebases that an object/array they're dealing with is ultimately a perhaps deeply-nested property of a global mutable object. I have unfortunately seen it happen before 🌞.

But of course this would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant