add duration logging to flushImpl and to waiting for prev flushes #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-mp
reviewed
Apr 24, 2024
| flushScheduledWithOutputGate = false; | ||
| })).then([this]() { | ||
| auto flushPromise = lastFlush.addBranch().attach( | ||
| util::DurationExceededLogger( |
There was a problem hiding this comment.
I don't think this works. Own<T> has an attachVal that would work like this, but kj::Promise doesn't have an attachVal. Maybe you can just heap allocate it and then move it here.
a-robinson
reviewed
Apr 24, 2024
| auto durationAlert = util::DurationExceededLogger( | ||
| clock, | ||
| 5 * kj::SECONDS, | ||
| "flushImpl took longer than expected" |
There was a problem hiding this comment.
This would be much more useful if it included some summary of the operations included in the flush. Or if it allowed us to distinguish between the actual flushing being slow and the waitForPastReads step being slow.
|
Closing this too, seems like most slowness here is usually driven by cpu usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to differentiate single flushes taking a long time vs the effect of multiple queued flushes causing issues.