Add SqliteDatabase::executeWithRegulator #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are `sqlite3` API functions that may prepare and execute their own internal statements. We need to call those functions with a regulator or we’ll summarily reject them. Adding a method to do this seemed like a clean way of handling these cases.
justin-mp
force-pushed
the
jmp/sqlite-executeWithRegulator
branch
from
1942089 to
5ff0c59
Compare
smerritt
approved these changes
Apr 25, 2024
| @@ -94,6 +94,9 @@ class SqliteDatabase { | |||
| // that was not processed. This is used for streaming SQL ingestion. | |||
| kj::StringPtr ingestSql(Regulator& regulator, kj::StringPtr sqlCode); | |||
|
|
|||
| // Execute a function with the given regulator. | |||
| void executeWithRegulator(Regulator& regulator, kj::FunctionParam<void()> func); | |||
There was a problem hiding this comment.
This looks good, but I've got one brain cell that won't quit screaming about something like
template <typename Ret, typename... Params>
Ret executeWithRegulator(Regulator& regulator, kj::FunctionParam<Ret(Params...)> func, Params... params) {
// ...
return func(kj::fwd<Params>(params)...);
Let's ignore that brain cell, though, since we can go back and generalize this later if we need to. YAGNI, blah blah blah.
kentonv
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are
sqlite3API functions that may prepare and execute their own internal statements. We need to call those functions with a regulator or we’ll summarily reject them. Adding a method to do this seemed like a clean way of handling these cases.