You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JSG_REQUIRE(nanos < int64_t(kj::maxValue), TypeError, "This API doesn't support dates after 2189.");
This isn't ideal, as some people (like me 😅 ), use Fri, 31 Dec 9999 23:59:59 GMT as their default "never expire" date for S3 bucket objects.
If R2 only uses milliseconds internally, shouldn't the Workers R2 bindings allow up to year 9999? (Based on the R2Object responses I see from .put, it looks like R2 only uses milliseconds, not nanoseconds. I could be wrong though.)
Presumably due to
toKjDate
, the R2 bindings are unable to use dates pastThu, 31 Dec 2189 23:59:59 GMT
(akanew Date("2189-12-31T23:59:59.999Z")
).workerd/src/workerd/jsg/value.h
Lines 1061 to 1075 in 4d32cdc
This isn't ideal, as some people (like me 😅 ), use
Fri, 31 Dec 9999 23:59:59 GMT
as their default "never expire" date for S3 bucket objects.If R2 only uses milliseconds internally, shouldn't the Workers R2 bindings allow up to year 9999? (Based on the
R2Object
responses I see from.put
, it looks like R2 only uses milliseconds, not nanoseconds. I could be wrong though.)The text was updated successfully, but these errors were encountered: