From da90341495b060df7623685f1107e928fee4dbd0 Mon Sep 17 00:00:00 2001 From: Milan Miladinovic Date: Mon, 15 Jan 2024 10:54:47 -0500 Subject: [PATCH] Decrease JS RPC message limit to 1MiB --- src/workerd/api/worker-rpc.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/workerd/api/worker-rpc.h b/src/workerd/api/worker-rpc.h index afb4f37ee981..13592c7b855b 100644 --- a/src/workerd/api/worker-rpc.h +++ b/src/workerd/api/worker-rpc.h @@ -20,10 +20,9 @@ namespace workerd::api { -// TODO(soon): This size limit is loosely based on Cap'n Proto's 'traversalLimitInWords'. -// JS RPC does not support streaming messages yet, and until it does we should prevent -// large messages from being sent. -constexpr size_t MAX_JS_RPC_MESSAGE_SIZE = 32 * 1024 * 1024; +// TODO(soon): JS RPC does not support streaming messages yet. Until it does, we should prevent +// large messages from being sent. This limits rpc messages to the same size as a WebSocket message. +constexpr size_t MAX_JS_RPC_MESSAGE_SIZE = 1u << 20; // A WorkerRpc object forwards JS method calls to the remote Worker/Durable Object over RPC. // Since methods are not known until runtime, WorkerRpc doesn't define any JS methods.