Skip to content

Commit 9fbfb64

Browse files
committed
Remove explicitly unimplemented importScripts
We have no plans to ever implement `importScripts()` and having it defined but marked explicitly non-implemented is causing issues with using certain third-party libraries in workers. So let's just remove it entirely. Refs: #1521
1 parent 29deae9 commit 9fbfb64

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/workerd/api/global-scope.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,11 @@ class PromiseRejectionEvent: public Event {
131131

132132
class WorkerGlobalScope: public EventTarget, public jsg::ContextGlobal {
133133
public:
134-
jsg::Unimplemented importScripts(kj::String s) { return {}; };
135-
136134
JSG_RESOURCE_TYPE(WorkerGlobalScope) {
137135
JSG_INHERIT(EventTarget);
138136

139137
JSG_NESTED_TYPE(EventTarget);
140138

141-
JSG_METHOD(importScripts);
142-
143139
JSG_TS_DEFINE(type WorkerGlobalScopeEventMap = {
144140
fetch: FetchEvent;
145141
scheduled: ScheduledEvent;

0 commit comments

Comments
 (0)