Skip to content

Commit

Permalink
Remove explicitly unimplemented importScripts
Browse files Browse the repository at this point in the history
We have no plans to ever implement `importScripts()` and having
it defined but marked explicitly non-implemented is causing issues
with using certain third-party libraries in workers. So let's just
remove it entirely.

Refs: #1521
  • Loading branch information
jasnell committed Jan 19, 2024
1 parent 29deae9 commit 9fbfb64
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/workerd/api/global-scope.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,11 @@ class PromiseRejectionEvent: public Event {

class WorkerGlobalScope: public EventTarget, public jsg::ContextGlobal {
public:
jsg::Unimplemented importScripts(kj::String s) { return {}; };

JSG_RESOURCE_TYPE(WorkerGlobalScope) {
JSG_INHERIT(EventTarget);

JSG_NESTED_TYPE(EventTarget);

JSG_METHOD(importScripts);

JSG_TS_DEFINE(type WorkerGlobalScopeEventMap = {
fetch: FetchEvent;
scheduled: ScheduledEvent;
Expand Down

0 comments on commit 9fbfb64

Please sign in to comment.