Merge pull request #3295 from cloudflare/dlapid/fix_trace_lifetime2

danlapid · web-flow · commit 1a12caabb7f2 · 2025-01-06T23:34:53.000Z
Dont mv out of arrayPtr in sendTracesToExportedHandler
diff --git a/src/workerd/api/trace.c++ b/src/workerd/api/trace.c++
@@ -659,7 +659,7 @@ kj::Promise<void> sendTracesToExportedHandler(kj::Own<IoContext::IncomingRequest
   auto nonEmptyTraces = kj::Vector<kj::Own<Trace>>(kj::size(traces));
   for (auto& trace: traces) {
     if (trace->eventInfo != kj::none) {
-      nonEmptyTraces.add(kj::mv(trace));
+      nonEmptyTraces.add(kj::addRef(*trace));
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ kj::Promise<void> sendTracesToExportedHandler(kj::Own<IoContext::IncomingRequest`
`659`	`659`	`auto nonEmptyTraces = kj::Vector<kj::Own<Trace>>(kj::size(traces));`
`660`	`660`	`for (auto& trace: traces) {`
`661`	`661`	`if (trace->eventInfo != kj::none) {`
`662`		`- nonEmptyTraces.add(kj::mv(trace));`
	`662`	`+ nonEmptyTraces.add(kj::addRef(*trace));`
`663`	`663`	`}`
`664`	`664`	`}`
`665`	`665`