Merge pull request #1714 from cloudflare/revert-1700-revert-1607-ggu/to-string-builtin-objects

Revert "Revert "Add toStringTag value on JSG resource types""

Author: garrettgu10

Diff for: src/workerd/jsg/jsg.h

@@ -47,6 +47,7 @@ namespace workerd::jsg {
       ::workerd::jsg::JsgKind::RESOURCE; \
   using jsgSuper = jsgThis; \
   using jsgThis = Type; \
+  static inline kj::StringPtr jsgGetName() { return #Type##_kjc; } \
   inline kj::StringPtr jsgGetMemoryName() const override { return #Type##_kjc; } \
   inline size_t jsgGetMemorySelfSize() const override { return sizeof(Type); } \
   inline void jsgGetMemoryInfo(jsg::MemoryTracker& tracker) const override { \

Diff for: src/workerd/jsg/resource.h

@@ -712,6 +712,9 @@ struct ResourceTypeBuilder {
     inspectProperties = v8::ObjectTemplate::New(isolate);
     prototype->Set(symbol, inspectProperties, static_cast<v8::PropertyAttribute>(
       v8::PropertyAttribute::ReadOnly | v8::PropertyAttribute::DontEnum));
+
+    auto toStringTagSymbol = v8::Symbol::GetToStringTag(isolate);
+    prototype->Set(toStringTagSymbol, v8StrIntern(isolate, Self::jsgGetName()), v8::PropertyAttribute::None);
   }
 
   template <typename Type, typename GetNamedMethod, GetNamedMethod getNamedMethod>

Diff for: src/workerd/jsg/wrappable.h

@@ -118,7 +118,7 @@ class Wrappable: public kj::Refcounted {
   virtual void jsgVisitForGc(GcVisitor& visitor);
 
   virtual kj::StringPtr jsgGetMemoryName() const {
-    KJ_UNIMPLEMENTED("jsgGetTypeName is not implemented. "
+    KJ_UNIMPLEMENTED("jsgGetMemoryName is not implemented. "
                      "It must be overridden by subclasses");
   }