fix(image): stop forcing object-fit on fill images - #3237
Open
JamesbbBriz wants to merge 1 commit into
Open
Conversation
Next.js builds its fill imgStyle from the legacy objectFit prop (usually undefined) and never sets an inline object-fit, leaving the value to the caller's style or stylesheet. vinext hardcoded objectFit: "cover", so fill images that need contain (logos, diagrams) rendered cropped from both top and bottom even though the docs pattern of passing objectFit through style is the supported escape hatch. Drop the hardcoded value so fill parity holds: the legacy objectFit prop still flows through style, explicit styles still win, and blur placeholder backgrounds keep their own cover sizing independent of this path.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
Contributor
Performance benchmarksCompared 0 improved · 0 regressed · 6 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next.js builds its fill
imgStylefrom the legacyobjectFitprop (usually undefined) and never sets an inlineobject-fit, leaving the value to the caller's style or stylesheet (get-img-props.jsassignsstylelast). vinext hardcodedobjectFit: "cover", so fill images that needcontain(logos, diagrams) rendered cropped even though passingobjectFitthroughstyleis the documented pattern.Drops the hardcoded value so fill parity holds: the legacy
objectFitprop still flows through style, explicit styles still win, and blur placeholder backgrounds keep their owncoversizing independent of this path.Fixes #3238