Skip to content

fix(check): ignore build output from other toolchains - #3231

Open
JamesbbBriz wants to merge 1 commit into
cloudflare:mainfrom
JamesbbBriz:fix/check-ignore-build-output-dirs
Open

fix(check): ignore build output from other toolchains#3231
JamesbbBriz wants to merge 1 commit into
cloudflare:mainfrom
JamesbbBriz:fix/check-ignore-build-output-dirs

Conversation

@JamesbbBriz

@JamesbbBriz JamesbbBriz commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Migrating an existing deployment (the documented OpenNext → vinext path) leaves build artifacts like .open-next/, .wrangler/, and .output/ next to the project root. The compatibility scan walked them and reported bundled worker code as application source: imports flagged as unsupported, CJS globals flagged as blockers, and the compatibility percentage dragged down by files the migration deletes anyway (we measured 79% on a Payload app that was fully compatible once the stale output was removed).

Extends the ignored-directory list and adds a regression test covering OpenNext and wrangler output.

Fixes #3232

Migrating an existing deployment (the documented OpenNext -> vinext
path) leaves build artifacts like .open-next/, .wrangler/, and .output/
next to the project root. The compatibility scan walked them and
reported bundled worker code as application source: imports flagged as
unsupported, CJS globals flagged as blockers, and the overall
compatibility percentage dragged down by files the migration deletes
anyway.

Extends the ignored-directory list and adds a regression test covering
OpenNext and wrangler output.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3231
npm i https://pkg.pr.new/create-vinext-app@3231
npm i https://pkg.pr.new/@vinext/types@3231
npm i https://pkg.pr.new/vinext@3231

commit: db05c72

@github-actions

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared db05c72 against base 13e7d9c using alternating same-runner rounds. Next.js was unchanged and skipped.

2 improved · 0 regressed · 4 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.4 KB 142.4 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.7 KB 129.7 KB ⚫ +0.0%
Dev server cold start vinext 3.37 s 3.32 s 🟢 -1.5%
Production build time vinext 3.79 s 3.70 s 🟢 -2.3%
RSC entry closure size (gzip) vinext 125.5 KB 125.5 KB ⚫ -0.0%
Server bundle size (gzip) vinext 216.2 KB 216.1 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vinext check reports false incompatibilities when other toolchains' build output exists (.open-next/, .wrangler/, .output/)

1 participant