Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cssparser and selectors dependencies to remove syn@1 transitive dependency #262

Open
emschwartz opened this issue Feb 7, 2025 · 1 comment · May be fixed by #264
Open

Update cssparser and selectors dependencies to remove syn@1 transitive dependency #262

emschwartz opened this issue Feb 7, 2025 · 1 comment · May be fixed by #264

Comments

@emschwartz
Copy link

syn is a notoriously slow crate to build. Most of the Rust ecosystem has moved from syn v1 to v2. However, lol_html indirectly depends on syn@1 (lol_html depends on [email protected] and [email protected], which depend on [email protected] -> [email protected] -> syn@1). This likely means that most projects using lol_html are including both versions of syn.

It would be nice to remove the syn@1 dependency to speed up compilation time.

As an aside: thanks for open sourcing this library!
@kornelski
Copy link
Contributor

#250 needs help.

@paolobarbolini paolobarbolini linked a pull request Mar 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Selectors cssparser upgrade paolobarbolini/lol-html
2 participants
@kornelski @emschwartz