Merge pull request #276 from nickysemenza/allow-unknown-protocol-tags

nickysemenza · web-flow · commit ddafcb29710d · 2020-09-10T12:59:16.000-07:00
diff --git a/protocol/protocol.go b/protocol/protocol.go
@@ -643,7 +643,8 @@ func (o *Operation) UnmarshalBinary(body []byte) error {
 		case TagCustomFuncName:
 			o.CustomFuncName = string(data)
 		default:
-			return fmt.Errorf("unknown tag: %02x", tag)
+			// Silently ignore any unknown tags (to allow for new tags to be gradually added to the protocol).
+			continue
 		}
 
 		// only use tag as an index in seen after we've validated that it's a tag

Original file line number	Diff line number	Diff line change
`@@ -643,7 +643,8 @@ func (o *Operation) UnmarshalBinary(body []byte) error {`
`643`	`643`	`case TagCustomFuncName:`
`644`	`644`	`o.CustomFuncName = string(data)`
`645`	`645`	`default:`
`646`		`- return fmt.Errorf("unknown tag: %02x", tag)`
	`646`	`+ // Silently ignore any unknown tags (to allow for new tags to be gradually added to the protocol).`
	`647`	`+ continue`
`647`	`648`	`}`
`648`	`649`
`649`	`650`	`// only use tag as an index in seen after we've validated that it's a tag`