Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added domains to compat matrix #18583

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

ToriLindsay
Copy link
Contributor

Fixes #17944

@ToriLindsay
Copy link
Contributor Author

@mikenomitch Would you be able to review? Feel free to let me know if you think this is too granular or isn't necessary.

Copy link

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6c9160
Status: ✅  Deploy successful!
Preview URL: https://4424f864.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://tori-pcx17944-add-domains-to.cloudflare-docs-7ou.pages.dev

View logs

@mikenomitch
Copy link
Contributor

@ToriLindsay this LGTM but I want to double check with @nevikashah that it is accurate!

| **Domain Configuration** | | |
| [Custom domains](/workers/configuration/routing/custom-domains/#add-a-custom-domain)| ✅ | ✅ |
| [Custom subdomains](/workers/configuration/routing/custom-domains/#set-up-a-custom-domain-in-the-dashboard)|✅|✅|
| [Custom domains outside Cloudflare zones](/pages/configuration/custom-domains/#add-a-custom-cname-record)|❌|✅|
Copy link
Member

@GregBrimble GregBrimble Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [Custom domains outside Cloudflare zones](/pages/configuration/custom-domains/#add-a-custom-cname-record)|||
| [Custom domains outside Cloudflare zones](/pages/configuration/custom-domains/#add-a-custom-cname-record)|||
| [Non-root Routes](https://developers.cloudflare.com/workers/configuration/routing/routes/) |||

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing imminently cc. @WalshyDev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orly? 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom domains to Workers vs. Pages-compatibility matrix
6 participants