|
| 1 | +# Contributing to cloudera.exe |
| 2 | + |
| 3 | +Thank you for considering contributions to the `cloudera.exe` Ansible collection! |
| 4 | + |
| 5 | +## Submitting a pull request |
| 6 | + |
| 7 | +You can start work on issues that are not yet part of a [Milestone](https://github.com/cloudera-labs/cloudera.exe/milestones) -- anything in our issue tracker that isn't assigned to a Milestone is considered the [backlog](https://github.com/cloudera-labs/cloudera.exe/issues?q=is%3Aopen+is%3Aissue+no%3Amilestone). |
| 8 | + |
| 9 | +Before you start working, please announce that you want to do so by commenting on the issue. _([Create an issue](https://github.com/cloudera-labs/cloudera.exe/issues/new?labels=enhancement) if there isn't one yet, and you can also check out our [Discussions](https://github.com/cloudera-labs/cloudera.exe/discussions) for ideas.)_ We try to ensure that all active work is assigned to a Milestone in order to keep our backlog accurate. |
| 10 | + |
| 11 | +**When your work is ready for review, create a branch in your own forked repository from the `devel` branch and submit a pull request against `devel`, referencing your the issue.** |
| 12 | + |
| 13 | +As a _best practice_, you can prefix your branches with: |
| 14 | + |
| 15 | +|prefix|Description|Example| |
| 16 | +|------|-----------|-------| |
| 17 | +|`feature/`|A new feature or changes existing to existing code or documentation|`feature/update-this-modules-params`| |
| 18 | +|`fix/`|A non-urgent bug fix|`fix/refactor-module-output-params`| |
| 19 | +|`hotfix/`|An urgent bug fix|`hotfix/patch-insecure-module`| |
| 20 | + |
| 21 | +> [!NOTE] |
| 22 | +> :fire_extinguisher: A **hotfix** should branch from `main`. It will then be committed to both the `main` and `devel` branches. |
| 23 | +
|
| 24 | +## Signing your commits |
| 25 | + |
| 26 | +Note that we require signed commits inline with [Developer Certificate of Origin](https://developercertificate.org/) best-practices for open source collaboration. |
| 27 | + |
| 28 | +A signed commit is a simple one-liner at the end of your commit message that states that you wrote the patch or otherwise have the right to pass the change into open source. Signing your commits means you agree to: |
| 29 | + |
| 30 | +``` |
| 31 | +Developer Certificate of Origin |
| 32 | +Version 1.1 |
| 33 | +
|
| 34 | +Copyright (C) 2004, 2006 The Linux Foundation and its contributors. |
| 35 | +660 York Street, Suite 102, |
| 36 | +San Francisco, CA 94110 USA |
| 37 | +
|
| 38 | +Everyone is permitted to copy and distribute verbatim copies of this |
| 39 | +license document, but changing it is not allowed. |
| 40 | +
|
| 41 | +
|
| 42 | +Developer's Certificate of Origin 1.1 |
| 43 | +
|
| 44 | +By making a contribution to this project, I certify that: |
| 45 | +
|
| 46 | +(a) The contribution was created in whole or in part by me and I |
| 47 | + have the right to submit it under the open source license |
| 48 | + indicated in the file; or |
| 49 | +
|
| 50 | +(b) The contribution is based upon previous work that, to the best |
| 51 | + of my knowledge, is covered under an appropriate open source |
| 52 | + license and I have the right under that license to submit that |
| 53 | + work with modifications, whether created in whole or in part |
| 54 | + by me, under the same open source license (unless I am |
| 55 | + permitted to submit under a different license), as indicated |
| 56 | + in the file; or |
| 57 | +
|
| 58 | +(c) The contribution was provided directly to me by some other |
| 59 | + person who certified (a), (b) or (c) and I have not modified |
| 60 | + it. |
| 61 | +
|
| 62 | +(d) I understand and agree that this project and the contribution |
| 63 | + are public and that a record of the contribution (including all |
| 64 | + personal information I submit with it, including my sign-off) is |
| 65 | + maintained indefinitely and may be redistributed consistent with |
| 66 | + this project or the open source license(s) involved. |
| 67 | +``` |
| 68 | + |
| 69 | +(See [developercertificate.org](https://developercertificate.org/)) |
| 70 | + |
| 71 | +To agree, make sure to add line at the end of every git commit message, like this: |
| 72 | + |
| 73 | +``` |
| 74 | +Signed-off-by: John Doe <[email protected]> |
| 75 | +``` |
| 76 | + |
| 77 | +> [!NOTE] |
| 78 | +> :rocket: TIP! Add the sign-off automatically when creating the commit via the `-s` flag, e.g. `git commit -s`. |
| 79 | +
|
| 80 | +## Still have questions? Opinions? Comments? |
| 81 | + |
| 82 | +Come find us on our [Discussions](https://github.com/cloudera-labs/cloudera.exe/discussions)! |
0 commit comments