Fix issue where Warnings relying on violation messages were not correctly producing string outputs for Environments

Signed-off-by: Daniel Chaffelson <[email protected]>

Author: Chaffelson

src/cdpy/environments.py

@@ -61,7 +61,7 @@ def describe_environment(self, name):
                 # Describe will fail in certain fault scenarios early in Environment creation
                 # We helpfully provide the summary listing as a backup set of information
                 # If the environment truly does not exist, then this will give the same response
-                self.sdk.throw_warning(CdpWarning(resp.violations['message']))
+                self.sdk.throw_warning(CdpWarning(resp.violations))
                 return self.summarize_environment(name)
             self.sdk.throw_error(resp)
         return resp
@@ -107,7 +107,7 @@ def create_aws_environment(self, **kwargs):
             if resp.error_code == 'INVALID_ARGUMENT':
                 if 'constraintViolations' not in resp.violations:
                     resp.update(message="Received violation warning:\n%s" % self.sdk.dumps(resp.violations))
-                    self.sdk.throw_warning(CdpWarning(resp.violations['message']))
+                    self.sdk.throw_warning(CdpWarning(resp.violations))
             self.sdk.throw_error(resp)
         return resp
 
@@ -121,7 +121,7 @@ def create_azure_environment(self, **kwargs):
             if resp.error_code == 'INVALID_ARGUMENT':
                 if 'constraintViolations' not in resp.violations:
                     resp.update(message="Received violation warning:\n%s" % self.sdk.dumps(resp.violations))
-                    self.sdk.throw_warning(CdpWarning(resp.violations['message']))
+                    self.sdk.throw_warning(CdpWarning(resp.violations))
             self.sdk.throw_error(resp)
         return resp
 
@@ -135,7 +135,7 @@ def create_gcp_environment(self, **kwargs):
             if resp.error_code == 'INVALID_ARGUMENT':
                 if 'constraintViolations' not in resp.violations:
                     resp.update(message="Received violation warning:\n%s" % self.sdk.dumps(resp.violations))
-                    self.sdk.throw_warning(CdpWarning(resp.violations['message']))
+                    self.sdk.throw_warning(CdpWarning(resp.violations))
             self.sdk.throw_error(resp)
         return resp
 
@@ -205,7 +205,7 @@ def sync_users(self, environments=None):
         )
         if isinstance(resp, CdpError):
             if resp.error_code == 'CONFLICT':
-                operation_match = self.sdk.regex_search(self.sdk.OPERATION_REGEX, resp.violations['message'])
+                operation_match = self.sdk.regex_search(self.sdk.OPERATION_REGEX, resp.violations)
                 if operation_match is not None:
                     existing_op_id = operation_match.group(1)
                     if not self.sdk.strict_errors:
@@ -264,11 +264,11 @@ def create_aws_credential(self, name, role, description, retries=3, delay=2):
                 consistency_violations = [
                     'Unable to verify credential', 'sts:AssumeRole', 'You are not authorized'
                 ]
-                if any(x in resp.violations['message'] for x in consistency_violations):
+                if any(x in resp.violations for x in consistency_violations):
                     retries = retries - 1
                     self.sdk.throw_warning(
                         CdpWarning('Got likely AWS IAM eventual consistency error [%s], %d retries left...'
-                                   % (resp.violations['message'], retries))
+                                   % (resp.violations, retries))
                     )
                     self.sdk.sleep(delay)
                     return self.create_aws_credential(name, role, description, retries, delay)