Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavinmqctl cluster_status shouldn't require entire url for remote host #908

Open
riffraff169 opened this issue Jan 13, 2025 · 0 comments
Open

Comments

@riffraff169
Copy link

Describe the bug
lavinqmctl cluster_status currently requires http://user:pass@remote_host:15672 to get status info. Help doesn't specify that, just says host

Describe your setup
lavinmq 2.0.0 recent pull as of today (I changed my local rpmbuild to say version 2.0.3). Rocky 9, Crystal 1.15.0, 3 nodes, etcd 3.5.16

How to reproduce
lavinqmctl cluster_status --host=lavinmq2
It returns:

# lavinmqctl cluster_status --host=lmq2
Unhandled exception: Missing scheme: lmq2 (ArgumentError)
  from lavinmqctl in '??'
  from lavinmqctl in '??'
  from lavinmqctl in '??'
  from lavinmqctl in '??'
  from lavinmqctl in '__crystal_main'
  from lavinmqctl in '??'
  from lavinmqctl in 'main'
  from /lib64/libc.so.6 in '??'
  from /lib64/libc.so.6 in '__libc_start_main'
  from lavinmqctl in '_start'
  from ???

Expected behavior
Host should be sufficient if everything is default. If port is different than 15672, then port could be specified. If user and pass are required, then they could be specified as well.
Either way, this error is not helpful, help info should be more clear what is required. I think full url should not be required unless something custom is being used. There should be sane defaults for everything except for host name.
Expected behavior should be same as `lavinmqctl cluster_status --host=http://user:pass@lmq2:15672
Default port should not be port 80, since it by default users 5672 for amqp and 15672 for admin.

# lavinmqctl cluster_status --host=http://lmq3
Error connecting to 'lmq3:80': No route to host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant