Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UI dialog of particular type when more than 2 options #40

Open
velios opened this issue Mar 17, 2024 · 3 comments
Open

Use UI dialog of particular type when more than 2 options #40

velios opened this issue Mar 17, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@velios
Copy link

velios commented Mar 17, 2024

First of all, thanks for the great plugin and the time you spent developing it. Sorry if some of my text is worded impolitely. I am not a native speaker and cannot formulate my thoughts as I would like.

When i enable Clojure LSP "choose" popup window changes to this type
image
If i switch off Clojure LSP and stay with Cursive only popup in same place looks like this
Screenshot 2024-03-17 at 22 39 28
But i don't think it's something Cursive special, looks like different types of embedded IDEA popup window.

And for recently added feature #31 it's third type of dialog in same in my taste situation
Screenshot 2024-03-17 at 22 40 20

The second type of dialogue is quite convenient to use because it has many options for customization to suit every taste. If it's not too difficult, you can turn it on as the default option in Clojure LSP.

@velios velios added the enhancement New feature or request label Mar 17, 2024
@ericdallo
Copy link
Member

I know about that difference and the problem is that we are kind of making magic since IntelliJ CE doesn't support LSP in a easy way, so for now this is the best popup I could make it work, but indeed the second popup is the ideal, if you find a way to improve this LMK, I can check it again in the future

@ericdallo ericdallo added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers labels Mar 23, 2024
@ericdallo ericdallo moved this to Ready for development in clojure-lsp-intellij Mar 23, 2024
@velios
Copy link
Author

velios commented Apr 22, 2024

I think rich dialog is named com.intellij.ui.components.JBScrollPane
image

Link to instructions for enabling this tool

@ericdallo
Copy link
Member

Thanks @velios, I use this tool but JBScrollPane is just a scroll panel, also the problem here is not building the UI, I managed to build a similar UI, but the problem is how to integrate with the goToDeclaration API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Ready for development
Development

No branches or pull requests

2 participants