Skip to content

Commit 770c692

Browse files
committed
PR feedback
1 parent eeca2f6 commit 770c692

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

project.clj

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
:test {:dependencies [[print-foo "1.0.2"]]}
4949
:dev {:global-vars {*warn-on-reflection* true}
5050
:dependencies [[org.clojure/clojurescript "1.10.520"]
51-
[org.clojure/core.async "1.3.618":exclusions [org.clojure/clojure org.clojure/tools.reader]]
51+
[org.clojure/core.async "1.3.618" :exclusions [org.clojure/clojure org.clojure/tools.reader]]
5252
[cider/piggieback "0.5.2"]
5353
[commons-io/commons-io "2.8.0"]]
5454
:repl-options {:nrepl-middleware [cider.piggieback/wrap-cljs-repl]}

src/refactor_nrepl/analyzer.clj

+6-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,12 @@
7878
;; Use `locking`, because AST analysis can perform arbitrary evaluation.
7979
;; Parallel analysis is not safe, especially as it can perform `require` calls.
8080
(locking core/require-lock ;; for both `require` and `aj/analyze-ns`
81-
(require ns) ;; ease the work for t.ana
81+
82+
;; Performing this `require` makes it more likely that t.ana will succeed.
83+
;; I believe it's because `require` will also require other namespaces recursively.
84+
;; t.ana does so in theory as well, but it's slightly more rigid,
85+
;; and/or does not always do the same exact thing the Clojure compiler would.
86+
(require ns)
8287
(let [opts {:passes-opts
8388
{:validate/unresolvable-symbol-handler shadow-unresolvable-symbol-handler
8489
:validate/throw-on-arity-mismatch false

0 commit comments

Comments
 (0)