Skip to content

Commit e563b93

Browse files
committed
fix rebase fallout
1 parent fe575cd commit e563b93

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

crates/core/src/host/instance_env.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ impl InstanceEnv {
187187
}
188188

189189
#[tracing::instrument(level = "trace", skip_all)]
190-
pub fn console_log(&self, level: LogLevel, record: &Record, bt: &dyn BacktraceProvider) {
190+
pub(crate) fn console_log(&self, level: LogLevel, record: &Record, bt: &dyn BacktraceProvider) {
191191
self.replica_ctx.logger.write(level, record, bt);
192192
log::trace!(
193193
"MOD({}): {}",
@@ -197,7 +197,7 @@ impl InstanceEnv {
197197
}
198198

199199
/// End a console timer by logging the span at INFO level.
200-
pub fn console_timer_end(&self, span: &TimingSpan, function: Option<&str>) {
200+
pub(crate) fn console_timer_end(&self, span: &TimingSpan, function: Option<&str>) {
201201
let elapsed = span.start.elapsed();
202202
let message = format!("Timing span {:?}: {:?}", &span.name, elapsed);
203203

crates/core/src/host/v8/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ use spacetimedb_client_api_messages::energy::ReducerBudget;
2727
use spacetimedb_datastore::locking_tx_datastore::MutTxId;
2828
use spacetimedb_datastore::traits::Program;
2929
use spacetimedb_lib::{ConnectionId, Identity, RawModuleDef, Timestamp};
30-
use spacetimedb_primitives::{ColId, IndexId, TableId};
31-
use spacetimedb_sats::Serialize;
3230
use spacetimedb_schema::auto_migrate::MigrationPolicy;
3331
use std::sync::{Arc, LazyLock};
3432
use std::time::Instant;

crates/core/src/host/v8/syscall.rs

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -937,23 +937,26 @@ fn console_log<'scope>(scope: &mut HandleScope<'scope>, args: FunctionCallbackAr
937937
.get_script_name(scope)
938938
.map(|s| s.to_rust_cow_lossy(scope, &mut buf));
939939

940+
let level = (level as u8).into();
941+
let trace = if level == LogLevel::Panic {
942+
JsStackTrace::from_current_stack_trace(scope)?
943+
} else {
944+
<_>::default()
945+
};
946+
947+
let env = env_on_isolate(scope);
948+
949+
let function = env.log_record_function();
940950
let record = Record {
941951
// TODO: figure out whether to use walltime now or logical reducer now (env.reducer_start)
942952
ts: chrono::Utc::now(),
943953
target: None,
944954
filename: filename.as_deref(),
945955
line_number: Some(frame.get_line_number() as u32),
956+
function,
946957
message: &msg,
947958
};
948959

949-
let level = (level as u8).into();
950-
let trace = if level == LogLevel::Panic {
951-
JsStackTrace::from_current_stack_trace(scope)?
952-
} else {
953-
<_>::default()
954-
};
955-
956-
let env = env_on_isolate(scope);
957960
env.instance_env.console_log(level, &record, &trace);
958961

959962
Ok(v8::undefined(scope).into())
@@ -1036,7 +1039,8 @@ fn console_timer_end<'scope>(
10361039
let exc = CodeError::from_code(scope, errno::NO_SUCH_CONSOLE_TIMER.get())?;
10371040
return Err(exc.throw(scope));
10381041
};
1039-
env.instance_env.console_timer_end(&span);
1042+
let function = env.log_record_function();
1043+
env.instance_env.console_timer_end(&span, function);
10401044

10411045
Ok(v8::undefined(scope).into())
10421046
}

0 commit comments

Comments
 (0)