You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the resize tests use a hash-helper to generate a valid hash for testing urls. This hash-helper does not use the same hash generation code as the actual API uses (which is bad because of duplication, maintenance and testing).
It would be better if the tests could use the same hash generation code as the application, however that is made difficult because (currently):
Hash generation doesn't take a URL, but takes actions and data.
The actions and data are set on req.params by the route-checker middleware.
The resize tests are currently written in a way that you pass the beginning of a url, which doesn't work for any querystring params.
The text was updated successfully, but these errors were encountered:
Currently, the resize tests use a hash-helper to generate a valid hash for testing urls. This hash-helper does not use the same hash generation code as the actual API uses (which is bad because of duplication, maintenance and testing).
It would be better if the tests could use the same hash generation code as the application, however that is made difficult because (currently):
req.params
by the route-checker middleware.The text was updated successfully, but these errors were encountered: