Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash Generation Needs Refactoring #67

Open
Asheboy opened this issue Jun 4, 2021 · 0 comments
Open

Hash Generation Needs Refactoring #67

Asheboy opened this issue Jun 4, 2021 · 0 comments

Comments

@Asheboy
Copy link
Member

Asheboy commented Jun 4, 2021

Currently, the resize tests use a hash-helper to generate a valid hash for testing urls. This hash-helper does not use the same hash generation code as the actual API uses (which is bad because of duplication, maintenance and testing).

It would be better if the tests could use the same hash generation code as the application, however that is made difficult because (currently):

  • Hash generation doesn't take a URL, but takes actions and data.
  • The actions and data are set on req.params by the route-checker middleware.
  • The resize tests are currently written in a way that you pass the beginning of a url, which doesn't work for any querystring params.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant