Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkroom sometimes returning the wrong number of crops #25

Open
benjaminparnell opened this issue Aug 28, 2014 · 0 comments
Open

Darkroom sometimes returning the wrong number of crops #25

benjaminparnell opened this issue Aug 28, 2014 · 0 comments

Comments

@benjaminparnell
Copy link
Contributor

Darkroom is sometimes return the wrong number of crops, even when they have been successfully modified. I ran into this on the Times+ CMS, when I was trying to fix PT 1987 and implement a way to send only the modified crop to darkroom instead of all of them.

      if (_.size(crops) !== numberOfCropsActual) {
        console.log('crops length:', _.size(crops))
        console.log(this.get('crops'), numberOfCropsActual)
        this.trigger('cropsFailed')
      }

http://git.io/RtTseQ

Sometimes Darkroom is returning the correct amount of crops, and sometimes it is not, which triggers the cropsFailed event. However, the crops are still persisted in the model, and still save properly when you save an article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant