Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Certain endpoints return a 200 status but are actually failures #59

Open
clo4 opened this issue Nov 2, 2021 · 0 comments
Open

Certain endpoints return a 200 status but are actually failures #59

clo4 opened this issue Nov 2, 2021 · 0 comments

Comments

@clo4
Copy link
Owner

clo4 commented Nov 2, 2021

I’ve already let Jamf School know about this by email, so until it’s fixed all I can do is work around this on my end.

There are 2 options:

  1. Do nothing (ignore the issue)
  2. Wrap the assertValid call in a try/catch that, on failure, will check if the JSON has a code property, and will run through the afterResponse checks again. This means I might need to abstract away the logic of the afterResponse hooks.

Option 2 is more complicated, but I feel like I might end up sticking with option 1. I’ll keep this issue open to track it though.

@clo4 clo4 changed the title Certain endpoints incorrectly return a 200 status but are actually failures Certain endpoints return a 200 status but are actually failures Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant