Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test-doc is failing #527

Closed
lread opened this issue Mar 8, 2023 · 2 comments
Closed

ci: test-doc is failing #527

lread opened this issue Mar 8, 2023 · 2 comments

Comments

@lread
Copy link
Collaborator

lread commented Mar 8, 2023

The test-doc test seems to be failing when testing a code block in the user guide:

;; fill the logs
(e/go driver "https://google.com")
(e/wait 2) ;; give ajax requests a chance to finish

(def reqs (dev/get-ajax driver))
;; you'd search for what you are interested in here
(def req (last reqs))

(dev/request-done? req)
;; => true

(dev/request-failed? req)
;; => nil

(dev/request-success? req)
;; => true

This test passes locally for me on PopOS.

On CI this test is run on macOS. Can't remember why not ubuntu at this point, but don't want to mess with an old decision right now.

In a test PR, I bumped the 2-second wait time to 10 seconds and the test passed (well 2 times anyways!).

I'll put that quick fix in for now.

@lread
Copy link
Collaborator Author

lread commented Mar 8, 2023

Update: gonna disable this code block for now, even with 10 second bump it has failed.

@lread
Copy link
Collaborator Author

lread commented Mar 8, 2023

Closed by #528

@lread lread closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant