#3 Apply phpstan, php-cs-fixer & rector rules

Author: njoubert-cleverage

.php-cs-fixer.dist.php

@@ -1,7 +1,7 @@
 <?php
 
 /*
- * This file is part of the CleverAge/ProcessBundle package.
+ * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
  * Copyright (c) Clever-Age
  *

src/DependencyInjection/CleverAgeFlysystemProcessExtension.php

@@ -1,8 +1,11 @@
-<?php declare(strict_types=1);
-/**
+<?php
+
+declare(strict_types=1);
+
+/*
  * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
- * Copyright (C) 2017-2019 Clever-Age
+ * Copyright (c) Clever-Age
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.

src/Task/FileFetchTask.php

@@ -1,8 +1,11 @@
-<?php declare(strict_types=1);
-/**
+<?php
+
+declare(strict_types=1);
+
+/*
  * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
- * Copyright (C) 2017-2019 Clever-Age
+ * Copyright (c) Clever-Age
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
@@ -20,7 +23,7 @@
 
 /**
  * Copy (or move) file from one filesystem to another, using Flysystem
- * Either get files using a file regexp, or take files from input
+ * Either get files using a file regexp, or take files from input.
  */
 class FileFetchTask extends AbstractConfigurableTask implements IterableTaskInterface
 {
@@ -75,8 +78,6 @@ public function next(ProcessState $state): bool
     }
 
     /**
-     * @param ProcessState $state
-     *
      * @throws \UnexpectedValueException
      * @throws \InvalidArgumentException
      * @throws FilesystemException
@@ -87,7 +88,7 @@ protected function findMatchingFiles(ProcessState $state): void
         if ($filePattern) {
             foreach ($this->sourceFS->listContents('/') as $file) {
                 if ('file' === $file['type']
-                    && preg_match($filePattern, $file['path'])
+                    && preg_match($filePattern, (string) $file['path'])
                     && !\in_array($file['path'], $this->matchingFiles, true)) {
                     $this->matchingFiles[] = $file['path'];
                 }
@@ -131,7 +132,7 @@ protected function doFileCopy(ProcessState $state, string $filename, bool $remov
         }
 
         if ($removeSource) {
-            $this->sourceFS->delete(sprintf('%s://%s', $prefixFrom, $filename));
+            $this->sourceFS->delete(\sprintf('%s://%s', $prefixFrom, $filename));
         }
 
         return $result ? $filename : null;

src/Task/FilesystemOptionTrait.php

@@ -1,8 +1,11 @@
-<?php declare(strict_types=1);
-/**
+<?php
+
+declare(strict_types=1);
+
+/*
  * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
- * Copyright (C) 2017-2019 Clever-Age
+ * Copyright (c) Clever-Age
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
@@ -17,20 +20,18 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Tools to use filesystem inside task configurations
+ * Tools to use filesystem inside task configurations.
  */
 trait FilesystemOptionTrait
 {
-    protected function configureFilesystemOption(OptionsResolver $resolver, $optionName): void
+    protected function configureFilesystemOption(OptionsResolver $resolver, string|array $optionName): void
     {
         $resolver->setRequired($optionName);
         $resolver->setAllowedTypes($optionName, 'string');
-        $resolver->setNormalizer($optionName, function (Options $options, $value) {
-            return new Filesystem($value);
-        });
+        $resolver->setNormalizer($optionName, fn (Options $options, $value) => new Filesystem($value));
     }
 
-    protected function getFilesystem(ProcessState $state, $optionName): FilesystemOperator
+    protected function getFilesystem(ProcessState $state, string $optionName): FilesystemOperator
     {
         return $this->getOption($state, $optionName);
     }

src/Task/ListContentTask.php

@@ -1,8 +1,11 @@
-<?php declare(strict_types=1);
-/**
+<?php
+
+declare(strict_types=1);
+
+/*
  * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
- * Copyright (C) 2017-2019 Clever-Age
+ * Copyright (c) Clever-Age
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
@@ -18,7 +21,7 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Iterate over the content of a filesystem
+ * Iterate over the content of a filesystem.
  */
 class ListContentTask extends AbstractConfigurableTask implements IterableTaskInterface
 {
@@ -40,14 +43,14 @@ protected function configureOptions(OptionsResolver $resolver): void
      */
     public function execute(ProcessState $state): void
     {
-        if ($this->fsContent === null || key($this->fsContent) === null) {
+        if (null === $this->fsContent || null === key($this->fsContent)) {
             $filesystem = $this->getFilesystem($state, 'filesystem');
             $pattern = $this->getOption($state, 'file_pattern');
 
             $this->fsContent = $this->getFilteredFilesystemContents($filesystem, $pattern);
         }
 
-        if (key($this->fsContent) === null) {
+        if (null === key($this->fsContent)) {
             $state->setSkipped(true);
             $this->fsContent = null;
         } else {
@@ -57,23 +60,23 @@ public function execute(ProcessState $state): void
 
     public function next(ProcessState $state): bool
     {
-        if (!is_array($this->fsContent)) {
+        if (!\is_array($this->fsContent)) {
             return false;
         }
 
         next($this->fsContent);
 
-        return key($this->fsContent) !== null;
+        return null !== key($this->fsContent);
     }
 
     /**
      * @throws FilesystemException
      */
-    protected function getFilteredFilesystemContents(FilesystemOperator $filesystem, string $pattern = null): array
+    protected function getFilteredFilesystemContents(FilesystemOperator $filesystem, ?string $pattern = null): array
     {
         $results = [];
         foreach ($filesystem->listContents('') as $item) {
-            if ($pattern === null || \preg_match($pattern, $item['path'])) {
+            if (null === $pattern || preg_match($pattern, (string) $item['path'])) {
                 $results[] = $item;
             }
         }

src/Task/RemoveFileTask.php

@@ -1,8 +1,11 @@
-<?php declare(strict_types=1);
-/**
+<?php
+
+declare(strict_types=1);
+
+/*
  * This file is part of the CleverAge/FlysystemProcessBundle package.
  *
- * Copyright (C) 2017-2019 Clever-Age
+ * Copyright (c) Clever-Age
  *
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
@@ -17,7 +20,7 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Remove a file from a filesystem
+ * Remove a file from a filesystem.
  */
 class RemoveFileTask extends AbstractConfigurableTask
 {