Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelling event on mobile triggering errors #751

Closed
leibowitz opened this issue Oct 23, 2020 · 0 comments · Fixed by #752
Closed

cancelling event on mobile triggering errors #751

leibowitz opened this issue Oct 23, 2020 · 0 comments · Fixed by #752

Comments

@leibowitz
Copy link
Contributor

Getting a lot of these error messages in the console while ordering elements on mobile:

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

Pointing to this preventDefault call:

react-sortable-hoc/src/SortableContainer/index.js

Lines 454 to 457 in 4efcaa2

// Prevent scrolling on mobile
if (typeof event.preventDefault === 'function') {
event.preventDefault();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check if event is cancelable before calling preventDefault leibowitz/react-sortable-hoc
1 participant
@leibowitz