Handle even more tidying

Author: ckormanyos

Diff for: ref_app/src/mcal/host/mcal_wdg_watchdog.h

@@ -8,15 +8,16 @@
 #ifndef MCAL_WDG_WATCHDOG_2013_12_11_H
   #define MCAL_WDG_WATCHDOG_2013_12_11_H
 
+  #include <mcal_wdg.h>
+
+  #include <util/utility/util_noncopyable.h>
+  #include <util/utility/util_time.h>
+
   #include <atomic>
   #include <cstdint>
   #include <functional>
   #include <thread>
 
-  #include <mcal_wdg.h>
-  #include <util/utility/util_noncopyable.h>
-  #include <util/utility/util_time.h>
-
   #if defined(_MSC_VER)
   #define  MCAL_WDG_NORETURN
   #else
@@ -90,7 +91,7 @@
 
         MCAL_WDG_NORETURN static auto thread_function() -> void
         {
-          std::this_thread::sleep_for(std::chrono::milliseconds(10U));
+          std::this_thread::sleep_for(std::chrono::milliseconds(static_cast<unsigned>(UINT8_C(10))));
 
           bool timeout_has_occurred = false;
 
@@ -100,7 +101,7 @@
             {
               print_timeout_message();
 
-              std::this_thread::sleep_for(std::chrono::milliseconds(500U));
+              std::this_thread::sleep_for(std::chrono::milliseconds(static_cast<unsigned>(UINT16_C(500))));
             }
             else
             {
@@ -109,7 +110,7 @@
                 timeout_has_occurred = true;
               }
 
-              std::this_thread::sleep_for(std::chrono::milliseconds(20U));
+              std::this_thread::sleep_for(std::chrono::milliseconds(static_cast<unsigned>(UINT8_C(20))));
             }
           }
         }
@@ -122,7 +123,7 @@
 
       template<const typename watchdog_base::base_timer_type::tick_type MyPeriod>
       std::atomic_flag watchdog<MyPeriod>::my_lock = ATOMIC_FLAG_INIT;
-    }
-  }
+    } // namespace wdg
+  } // namespace mcal
 
 #endif // MCAL_WDG_WATCHDOG_2013_12_11_H

Diff for: ref_app/src/mcal_led/mcal_led_boolean_state_base.h

@@ -12,7 +12,7 @@
 
   namespace mcal { namespace led {
 
-  class led_boolean_state_base : public mcal::led::led_base
+  class led_boolean_state_base : public mcal::led::led_base // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)
   {
   protected:
     constexpr led_boolean_state_base() = default;
@@ -31,6 +31,7 @@
     bool is_on { };
   };
 
-  } } // namespace mcal::led
+  } // namespace led
+  } // namespace mcal
 
 #endif // MCAL_LED_BOOLEAN_STATE_BASE_2020_08_07_H

Diff for: ref_app/src/mcal_led/mcal_led_console.h

@@ -39,6 +39,7 @@
     const std::uint_fast8_t my_index;
   };
 
-  } } // namespace mcal::led
+  } // namespace led
+  } // namespace mcal
 
 #endif // MCAL_LED_CONSOLE_2020_04_23_H

Diff for: ref_app/src/mcal_led/mcal_led_pwm.h

@@ -40,6 +40,7 @@
     mcal::pwm::pwm_base& my_pwm;
   };
 
-  } } // namespace mcal::led
+  } // namespace led
+  } // namespace mcal
 
 #endif // MCAL_LED_PWM_2020_04_23_H

Diff for: ref_app/src/mcal_led/mcal_led_rgb_base.h

@@ -94,6 +94,7 @@
     }
   };
 
-  } } // namespace mcal::led
+  } // namespace led
+  } // namespace mcal
 
 #endif // MCAL_LED_RGB_BASE_2023_07_12_H

Diff for: ref_app/src/mcal_pwm/mcal_pwm_console.h

@@ -50,6 +50,7 @@
     ~pwm_console() override = default;
   };
 
-  } }
+  } // namespace pwm
+  } // namespace mcal
 
 #endif // MCAL_PWM_CONSOLE_2020_04_12_H_

Diff for: ref_app/src/mcal_spi/mcal_spi_software_dummy.h

@@ -12,7 +12,7 @@
 
   namespace mcal { namespace spi {
 
-  class spi_software_dummy : public util::communication_buffer_depth_one_byte
+  class spi_software_dummy : public util::communication_buffer_depth_one_byte // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)
   {
   private:
     using base_class_type = util::communication_buffer_depth_one_byte;

Diff for: ref_app/src/os/os.h

@@ -5,8 +5,8 @@
 //  or copy at http://www.boost.org/LICENSE_1_0.txt)
 //
 
-#ifndef OS_2011_10_20_H_
-  #define OS_2011_10_20_H_
+#ifndef OS_2011_10_20_H
+  #define OS_2011_10_20_H
 
   #include <os/os_cfg.h>
   #include <util/utility/util_time.h>
@@ -26,6 +26,6 @@
     auto set_event  (const task_id_type task_id, const event_type& event_to_set) -> bool;
     auto get_event  (event_type& event_to_get) -> void;
     auto clear_event(const event_type& event_to_clear) -> void;
-  }
+  } // namespace os
 
-#endif // OS_2011_10_20_H_
+#endif // OS_2011_10_20_H

Diff for: ref_app/src/os/os_cfg.h

@@ -15,16 +15,38 @@
   #include <util/utility/util_time.h>
 
   // Declare the task initialization and the task function of the idle process.
-  namespace sys { namespace idle { auto task_init() noexcept -> void; auto task_func() -> void; } }
+  namespace sys { namespace idle {
+
+  auto task_init() noexcept -> void; auto task_func() -> void;
+
+  } // namespace idle
+  } // namespace sys
 
   // Define symbols for the task initialization and the task function of the idle process.
   #define OS_IDLE_TASK_INIT() sys::idle::task_init()
   #define OS_IDLE_TASK_FUNC() sys::idle::task_func()
 
   // Declare all of the task initializations and the task functions.
-  namespace app { namespace led       { auto task_init() -> void; auto task_func() -> void; } }
-  namespace app { namespace benchmark { auto task_init() -> void; auto task_func() -> void; } }
-  namespace sys { namespace mon       { auto task_init() -> void; auto task_func() -> void; } }
+  namespace app { namespace led {
+
+  auto task_init() -> void; auto task_func() -> void;
+
+  } // namespace led
+  } // namespace app
+
+  namespace app { namespace benchmark {
+
+  auto task_init() -> void; auto task_func() -> void;
+
+  } // namespace benchmark
+  } // namespace app
+
+  namespace sys { namespace mon {
+
+  auto task_init() -> void; auto task_func() -> void;
+
+  } // namespace mon
+  } // namespace sys
 
   namespace os
   {
@@ -50,7 +72,7 @@
 
     static_assert(std::numeric_limits<os::event_type>::digits >= 16,
                   "The operating system event_type must be at least 16-bits wide.");
-  }
+  } // namespace os
 
   // Configure the operating system tasks.
 

Diff for: ref_app/src/os/os_task_control_block.h

@@ -19,10 +19,10 @@
     class task_control_block final
     {
     public:
-      task_control_block(const function_type init,
-                         const function_type func,
-                         const tick_type cycle,
-                         const tick_type offset)
+      task_control_block(const function_type init, // NOLINT(bugprone-easily-swappable-parameters)
+                         const function_type func, // NOLINT(bugprone-easily-swappable-parameters)
+                         const tick_type cycle,    // NOLINT(bugprone-easily-swappable-parameters)
+                         const tick_type offset)   // NOLINT(bugprone-easily-swappable-parameters)
         : my_init  { init },
           my_func  { func },
           my_cycle { cycle },

Diff for: ref_app/src/util/utility/util_communication.h

@@ -17,7 +17,7 @@
 
   namespace util
   {
-    class communication_base : private util::noncopyable
+    class communication_base : private util::noncopyable // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)
     {
     public:
       virtual ~communication_base() = default;

Diff for: ref_app/src/util/utility/util_time.h

@@ -90,7 +90,7 @@
       {
         const timer t_delay(delay);
 
-        while(!t_delay.timeout())
+        while(!t_delay.timeout()) // NOLINT(altera-id-dependent-backward-branch)
         {
           mcal::wdg::secure::trigger();
         }