Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development server #10043

Closed
christianztamayo opened this issue Jul 1, 2021 · 4 comments
Closed

Local development server #10043

christianztamayo opened this issue Jul 1, 2021 · 4 comments
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@christianztamayo
Copy link

christianztamayo commented Jul 1, 2021

Hi,

I just got back from a long break. I had a PR/feature request way back on the now archived repo ckeditor/ckeditor5-build-classic regarding the implementation of a local development server to help with editor and plugin development:
ckeditor/ckeditor5-build-classic#94

I was just wondering if I can still re-open a PR for this feature request and if it's still relevant with the current state of ckeditor5? Thanks!


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@christianztamayo christianztamayo added the type:improvement This issue reports a possible enhancement of an existing feature. label Jul 1, 2021
@Mgsy
Copy link
Member

Mgsy commented Jul 5, 2021

Hi! The ckeditor5-build-classic repository is not maintained anymore, since we've migrated to monorepo. Currently, all pull requests should be created in this repository, so feel free to open a new one. As I can see your changes were already reviewed by @Reinmar, so you can put the link to your old PR with the whole discussion - it will help a new reviewer in catching up. 

Also, I'd like to ask you for one thing - before you open a pull request, could you please edit your post and add a description of the problem you'd like to solve with your PR? Thanks!

christianztamayo added a commit to christianztamayo/ckeditor5 that referenced this issue Jul 20, 2021
Helps improve productivity with live reload via webpack-dev-server.
Useful for developing plugins, doing customizations, etc.
Starts the server by running `yarn start` inside a build package's directory.

Affects ckeditor5-build-* packages:
- ckeditor5-build-balloon
- ckeditor5-build-balloon-block
- ckeditor5-build-classic
- ckeditor5-build-decoupled-document
- ckeditor5-build-inline
@adamerose
Copy link

I'd like to see this implemented too. But I think this PR is outdated now since the master branch is now using webpack 5 and this PR only works for webpack 4

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Oct 31, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants