Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ckeditor4-integrations-common #201

Closed
MMMalik opened this issue Jun 21, 2021 · 1 comment
Closed

Upgrade ckeditor4-integrations-common #201

MMMalik opened this issue Jun 21, 2021 · 1 comment
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@MMMalik
Copy link
Contributor

MMMalik commented Jun 21, 2021 •
edited
Loading

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

There is a new major version of ckeditor4-integrations-common package available as per this PR. It should be used downstream in the integrations to reduce library sizes.

⚠️ Warning ⚠️

This is potentially a breaking change. Version 1.0.0 of ckeditor4-integrations-common does not contain Promise polyfill anymore. Some downstream packages might (unknowingly) rely on that polyfill though. New major version of ckeditor4-angular might be required for this change.
@MMMalik MMMalik added status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). size:XS labels Jun 21, 2021
@MMMalik MMMalik changed the title Upgrade ckeditor4-integrations common Upgrade ckeditor4-integrations-common Jul 1, 2021
@MMMalik MMMalik mentioned this issue Jul 1, 2021
Closed
@Dumluregn Dumluregn mentioned this issue Jul 15, 2021
Open
3 tasks
@Dumluregn
Copy link
Collaborator

Done in #207. Note about releasing the next major was moved to #209.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dumluregn @MMMalik