Skip to content

Commit 553e879

Browse files
authored
Fix django versions in test matrix (#18)
* try to fix which versions of django are used during tests... * label django test step better * tweak label again.. test if requirements change is "taking" * replace requirements right as it's used, lost between steps? * cat requirements... * make sed write in place * try reducing drf so it works with django 1.11 * remove cruft, she workin!
1 parent 87792b0 commit 553e879

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/pythonpackage.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ jobs:
1919
uses: actions/setup-python@v1
2020
with:
2121
python-version: ${{ matrix.python-version }}
22-
- name: Set up Django ${{ matrix.django-version }}
23-
run: |
24-
sed 's/Django==.*/Django==${{ matrix.django-version }}/' requirements.txt
2522
- name: Cache pip
2623
uses: actions/cache@v1
2724
with:
@@ -33,7 +30,8 @@ jobs:
3330
${{ runner.os }}-
3431
- name: Install dependencies
3532
run: |
36-
python -m pip install --upgrade pip
33+
echo "Django version set to '${{ matrix.django-version }}' in requirements.txt"
34+
sed -i 's/Django==.*/Django${{ matrix.django-version }}/' requirements.txt
3735
pip install -r requirements.txt
3836
- name: Lint with flake8
3937
run: |

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ twine==3.1.1
33

44
# django stuff
55
Django==3.1.8
6-
djangorestframework==3.12.2
6+
djangorestframework==3.11.2
77

88
# tests
99
pytest==5.4.1

0 commit comments

Comments
 (0)