Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between standalone DS2438 sensors and AAG TAI-8540 sensors #10

Open
ckamps opened this issue Jan 12, 2020 · 3 comments
Open
Labels
bug Something isn't working

Comments

@ckamps
Copy link
Owner

ckamps commented Jan 12, 2020

Related to #5, but the parent driver needs to be able to distinguish between standalone DS2438 sensors for which the temperature only child driver is appropriate and the AAG TAI-8540 humidity + temperature sensor that uses a DS2438 sensor as its interface to the 1-Wire network.

Currently, the parent driver misidentifies standalone DS2438 sensors as being humidity + temperature sensors.

@ckamps
Copy link
Owner Author

ckamps commented Jan 12, 2020

Here's some code from the digitemp application that distinguishes between standalone DS2438 and humidity-capable sensors:

https://github.com/bcl/digitemp/blob/82f50e2d8dce147a89742c2b26dd342a7fd4efd0/src/digitemp.c#L1432

We should be able to dig into that code to learn the low-level interfaces and data needed to distinguish and then update the parent driver to use the low-level interfaces to the HA7Net to do the same. Since we'll be using low-level interfaces on the HA7Net, we'll also use the new locking support of the parent driver for concurrency management.

ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
 #5 #10 - update docs to make it more clear when specific child drive…
ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
ckamps added a commit that referenced this issue Jan 12, 2020
@ckamps
Copy link
Owner Author

ckamps commented Jan 12, 2020

More code/logic examples of working at a low level with DS2438 sensors:

https://eds.zendesk.com/hc/en-us/articles/214484863-Working-with-the-DS2438-using-the-HA7E-HA7S

@ckamps
Copy link
Owner Author

ckamps commented Jan 13, 2020

This issue has been partly fixed via recent commits and merges and tested by a user who has DS2438 sensors.

The current detection is a kludge and needs to be beefed up to more reliably detect standalone DS2438 sensors. Perhaps via low-level interfaces through the HA7Net.

@ckamps ckamps added the bug Something isn't working label Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant