Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'botname' setting is inconsistent #336

Open
Torgen opened this issue Jul 21, 2018 · 0 comments
Open

'botname' setting is inconsistent #336

Torgen opened this issue Jul 21, 2018 · 0 comments

Comments

@Torgen
Copy link
Contributor

Torgen commented Jul 21, 2018

While hubot.coffee tests Meteor.settings for a botname field which determines the name by which the bot can be addressed, the bot's name when speaking is always codexbot, which is also assumed by client-side code. 'botname' should be set in the public part of settings and used as the name the bot speaks as. (Yes, even though everyone says bot instead of codexbot.)
Torgen added a commit to Torgen/codex-blackboard that referenced this issue Jan 5, 2019
@Torgen
Allow setting the bot's name and gravatar
172f355 
Formerly you could set the name the bot responded to, but its display name would always be codexbot. Now you can set its display name with the botname setting/BOTNAME environment variable, and its gravatar with the botgravatar setting/BOTGRAVATAR environment variable.
On the client side, the latest botname is detected with a 'bot_wakeup' field.
Disallows logging in as any name the bot has ever used.
Will address cjb#336 but depends on the custom login handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Torgen