From d1cb537a6ea57be6e4049bb1527ffcfcfb92a22e Mon Sep 17 00:00:00 2001 From: Stephane Bounmy Date: Sun, 30 Sep 2012 11:38:15 +0200 Subject: [PATCH 01/25] if ajax request, do not paginate --- app/controllers/spree/admin/uploads_controller.rb | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/controllers/spree/admin/uploads_controller.rb b/app/controllers/spree/admin/uploads_controller.rb index 03b6201..5797253 100644 --- a/app/controllers/spree/admin/uploads_controller.rb +++ b/app/controllers/spree/admin/uploads_controller.rb @@ -1,16 +1,20 @@ class Spree::Admin::UploadsController < Spree::Admin::ResourceController - + def index render :template => "spree/admin/uploads/#{request.xhr? ? 'picker' : 'index'}", :layout => !request.xhr? end - + private - + def collection params[:q] ||= {} params[:q][:sort] ||= "created_at.desc" @search = Spree::Upload.search(params[:q]) - @collection = @search.result.page(params[:page]).per(Spree::Config[:orders_per_page]) + if request.xhr? + @collection = @search.result + else + @collection = @search.result.page(params[:page]).per(Spree::Config[:orders_per_page]) + end end end From 109d7ed0c3378ef4d8954b0fd04cb3bfc7deec6f Mon Sep 17 00:00:00 2001 From: Ben-M Date: Sun, 21 Oct 2012 16:56:42 +0200 Subject: [PATCH 02/25] Update version, added spree_auth_devise for testing. Still need to fix failing integration tests. --- Gemfile | 4 +++- Versionfile | 1 + spree_essentials.gemspec | 4 ++-- test/dummy_hooks/before_migrate.rb | 8 ++++++-- .../integration/spree/admin/extension_integration_test.rb | 2 +- 5 files changed, 13 insertions(+), 6 deletions(-) diff --git a/Gemfile b/Gemfile index 18a1a38..b304599 100644 --- a/Gemfile +++ b/Gemfile @@ -2,5 +2,7 @@ source "http://rubygems.org" gemspec group :development, :test do + gem "spree_auth_devise", "~> 1.0.0", :git => "git://github.com/spree/spree_auth_devise" gem "spree_essential_example", :path => "test/spree_essential_example" -end + gem 'coffee-rails' +end \ No newline at end of file diff --git a/Versionfile b/Versionfile index 66b041f..a2a7e9a 100644 --- a/Versionfile +++ b/Versionfile @@ -1,3 +1,4 @@ +"1.2.x" => { :version => "0.6.0" } "1.1.x" => { :version => "0.5.0" } "1.0.x" => { :version => "0.4.0" } "0.70.x" => { :version => "0.3.2" } diff --git a/spree_essentials.gemspec b/spree_essentials.gemspec index 68f6c01..6dbe067 100644 --- a/spree_essentials.gemspec +++ b/spree_essentials.gemspec @@ -18,7 +18,7 @@ Gem::Specification.new do |s| s.require_paths = ["lib"] - s.add_runtime_dependency('spree_core', '~> 1.1.0') + s.add_runtime_dependency('spree', '~> 1.2.0') s.add_runtime_dependency('rdiscount', '~> 1.6.8') s.add_development_dependency('shoulda', '~> 3.0.0') @@ -29,4 +29,4 @@ Gem::Specification.new do |s| s.add_development_dependency('simplecov', '~> 0.6.1') # s.add_development_dependency('turn', '~> 0.9.3') -end +end \ No newline at end of file diff --git a/test/dummy_hooks/before_migrate.rb b/test/dummy_hooks/before_migrate.rb index b1a3c33..c3692a4 100644 --- a/test/dummy_hooks/before_migrate.rb +++ b/test/dummy_hooks/before_migrate.rb @@ -1,10 +1,14 @@ -# Require spree_essential_example in config/application.rb +# Require spree_essential_example and spree_atuh in config/application.rb gsub_file "config/application.rb", 'require "spree_essentials"', %(require "spree_essentials" -require "spree_essential_example") +require "spree_essential_example" +require "spree_auth_devise") # Install spree's migrations rake "spree:install:migrations" +#Install spree auth migrations +rake "spree_auth:install:migrations" + # Mount the Spree::Core routes insert_into_file File.join('config', 'routes.rb'), :after => "Application.routes.draw do\n" do " # Mount Spree's routes\n mount Spree::Core::Engine, :at => '/'\n" diff --git a/test/integration/spree/admin/extension_integration_test.rb b/test/integration/spree/admin/extension_integration_test.rb index ce4e337..65fabce 100644 --- a/test/integration/spree/admin/extension_integration_test.rb +++ b/test/integration/spree/admin/extension_integration_test.rb @@ -7,7 +7,6 @@ class Spree::Admin::ExtensionIntegrationTest < SpreeEssentials::IntegrationCase end context "When no extensions are registered" do - should "have a contents tab with only uploads in the sub nav" do visit spree.admin_orders_path within "#admin-menu" do @@ -33,6 +32,7 @@ class Spree::Admin::ExtensionIntegrationTest < SpreeEssentials::IntegrationCase end should "have a contents tab with examples and uploads in the sub nav" do + #Spree::Admin::BaseController.any_instance.stub(:authorize_admin).and_return(false) visit spree.admin_orders_path within "#admin-menu" do assert has_link?("Content") From a0de02fdbca900f1d3d94ae76a201d1efa15e567 Mon Sep 17 00:00:00 2001 From: Ben-M Date: Mon, 22 Oct 2012 12:30:47 +0200 Subject: [PATCH 03/25] complete version bump --- lib/spree_essentials/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spree_essentials/version.rb b/lib/spree_essentials/version.rb index c40c98c..f6f3522 100644 --- a/lib/spree_essentials/version.rb +++ b/lib/spree_essentials/version.rb @@ -1,3 +1,3 @@ module SpreeEssentials - VERSION = "0.5.0" + VERSION = "0.6.0" end From b033c7b0c5977f66068116b826d78966d16cb643 Mon Sep 17 00:00:00 2001 From: Ben-M Date: Mon, 22 Oct 2012 13:18:55 +0200 Subject: [PATCH 04/25] update after_migrate hooks to seed an admin user --- test/dummy_hooks/after_migrate.rb.sample | 1 + 1 file changed, 1 insertion(+) diff --git a/test/dummy_hooks/after_migrate.rb.sample b/test/dummy_hooks/after_migrate.rb.sample index 941f06b..b0a39a6 100644 --- a/test/dummy_hooks/after_migrate.rb.sample +++ b/test/dummy_hooks/after_migrate.rb.sample @@ -1 +1,2 @@ rake "db:migrate db:seed", :env => "development" +rake "spree_auth:admin:create" \ No newline at end of file From cd352a6fe1c096c8efbb08be89607a972877ce9c Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:29:58 +1100 Subject: [PATCH 05/25] Remove spree_auth_devise dependency We don't need to care about authenticating as users here, as we can just stub out the API for authorization in admin controllers --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index b304599..3a588c5 100644 --- a/Gemfile +++ b/Gemfile @@ -2,7 +2,6 @@ source "http://rubygems.org" gemspec group :development, :test do - gem "spree_auth_devise", "~> 1.0.0", :git => "git://github.com/spree/spree_auth_devise" gem "spree_essential_example", :path => "test/spree_essential_example" gem 'coffee-rails' end \ No newline at end of file From 0045ea91b4645641f27f601cdf191ee7fd54f8fe Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:31:42 +1100 Subject: [PATCH 06/25] Add stub_authorization! helper and use it in extension_integration_test --- lib/spree_essentials/testing/integration_case.rb | 8 ++++++++ lib/spree_essentials/testing/test_helper.rb | 1 + spree_essentials.gemspec | 2 ++ test/dummy_hooks/before_migrate.rb | 6 +----- test/dummy_hooks/templates/spree_user_error_fix.rb | 4 +--- .../integration/spree/admin/extension_integration_test.rb | 1 + 6 files changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/spree_essentials/testing/integration_case.rb b/lib/spree_essentials/testing/integration_case.rb index 5fb120c..0942d54 100644 --- a/lib/spree_essentials/testing/integration_case.rb +++ b/lib/spree_essentials/testing/integration_case.rb @@ -23,6 +23,14 @@ class SpreeEssentials::IntegrationCase < ActiveSupport::TestCase def spree Spree::Core::Engine.routes.url_helpers end + + # Stub authorization for all admin controllers + def stub_authorization! + subclasses = Spree::Admin::BaseController.subclasses + Spree::Admin::ResourceController.subclasses + subclasses.each do |klass| + klass.any_instance.stubs(:authorize!).returns(true) + end + end # An assertion for ensuring content has made it to the page. # diff --git a/lib/spree_essentials/testing/test_helper.rb b/lib/spree_essentials/testing/test_helper.rb index 378dc07..bff96de 100644 --- a/lib/spree_essentials/testing/test_helper.rb +++ b/lib/spree_essentials/testing/test_helper.rb @@ -13,6 +13,7 @@ end require "rails/test_help" +require "mocha" require "shoulda" require "paperclip/matchers" require "factory_girl" diff --git a/spree_essentials.gemspec b/spree_essentials.gemspec index 6dbe067..56a8585 100644 --- a/spree_essentials.gemspec +++ b/spree_essentials.gemspec @@ -21,6 +21,8 @@ Gem::Specification.new do |s| s.add_runtime_dependency('spree', '~> 1.2.0') s.add_runtime_dependency('rdiscount', '~> 1.6.8') + s.add_development_dependency 'm' + s.add_development_dependency('mocha', '~> 0.12.7') s.add_development_dependency('shoulda', '~> 3.0.0') s.add_development_dependency('dummier', '~> 0.3.0') s.add_development_dependency('factory_girl', '~> 2.6.0') diff --git a/test/dummy_hooks/before_migrate.rb b/test/dummy_hooks/before_migrate.rb index c3692a4..64eff72 100644 --- a/test/dummy_hooks/before_migrate.rb +++ b/test/dummy_hooks/before_migrate.rb @@ -1,14 +1,10 @@ # Require spree_essential_example and spree_atuh in config/application.rb gsub_file "config/application.rb", 'require "spree_essentials"', %(require "spree_essentials" -require "spree_essential_example" -require "spree_auth_devise") +require "spree_essential_example") # Install spree's migrations rake "spree:install:migrations" -#Install spree auth migrations -rake "spree_auth:install:migrations" - # Mount the Spree::Core routes insert_into_file File.join('config', 'routes.rb'), :after => "Application.routes.draw do\n" do " # Mount Spree's routes\n mount Spree::Core::Engine, :at => '/'\n" diff --git a/test/dummy_hooks/templates/spree_user_error_fix.rb b/test/dummy_hooks/templates/spree_user_error_fix.rb index 86da9db..755687b 100644 --- a/test/dummy_hooks/templates/spree_user_error_fix.rb +++ b/test/dummy_hooks/templates/spree_user_error_fix.rb @@ -1,3 +1 @@ -unless Spree::User.const_defined?(:DestroyWithOrdersError) - class Spree::User::DestroyWithOrdersError < StandardError; end -end +Spree.user_class = "Spree::LegacyUser" diff --git a/test/integration/spree/admin/extension_integration_test.rb b/test/integration/spree/admin/extension_integration_test.rb index 65fabce..a3f3817 100644 --- a/test/integration/spree/admin/extension_integration_test.rb +++ b/test/integration/spree/admin/extension_integration_test.rb @@ -4,6 +4,7 @@ class Spree::Admin::ExtensionIntegrationTest < SpreeEssentials::IntegrationCase setup do SpreeEssentials.essentials.clear + stub_authorization! end context "When no extensions are registered" do From 7ff346d76060f732e77f792c378e120702f99c72 Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:52:11 +1100 Subject: [PATCH 07/25] Require sass-rails and jquery-rails gems as development dependencies --- spree_essentials.gemspec | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spree_essentials.gemspec b/spree_essentials.gemspec index 56a8585..67a65d0 100644 --- a/spree_essentials.gemspec +++ b/spree_essentials.gemspec @@ -29,6 +29,8 @@ Gem::Specification.new do |s| s.add_development_dependency('capybara', '~> 1.1.2') s.add_development_dependency('sqlite3', '~> 1.3.4') s.add_development_dependency('simplecov', '~> 0.6.1') + s.add_development_dependency('sass-rails', '~> 3.2.5') + s.add_development_dependency('jquery-rails', '~> 2.1.3') # s.add_development_dependency('turn', '~> 0.9.3') -end \ No newline at end of file +end From f09bd1991bbc6ef9f3811fd33419c3cf6bc2d921 Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:52:21 +1100 Subject: [PATCH 08/25] Specify jquery dependencies inside admin/all.js template --- test/dummy_hooks/templates/admin/all.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/dummy_hooks/templates/admin/all.js b/test/dummy_hooks/templates/admin/all.js index a3b2c53..7623dee 100644 --- a/test/dummy_hooks/templates/admin/all.js +++ b/test/dummy_hooks/templates/admin/all.js @@ -1 +1,5 @@ +//= require jquery +//= require jquery_ujs //= require admin/spree_core +//= require_tree . + From 375da5c9b6238cdc4be78c7d5c821ba6d04082a1 Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:52:35 +1100 Subject: [PATCH 09/25] Remove commented out line from extension_integration_test --- test/integration/spree/admin/extension_integration_test.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/test/integration/spree/admin/extension_integration_test.rb b/test/integration/spree/admin/extension_integration_test.rb index a3f3817..a125adb 100644 --- a/test/integration/spree/admin/extension_integration_test.rb +++ b/test/integration/spree/admin/extension_integration_test.rb @@ -33,7 +33,6 @@ class Spree::Admin::ExtensionIntegrationTest < SpreeEssentials::IntegrationCase end should "have a contents tab with examples and uploads in the sub nav" do - #Spree::Admin::BaseController.any_instance.stub(:authorize_admin).and_return(false) visit spree.admin_orders_path within "#admin-menu" do assert has_link?("Content") From d169b9f116ebc3098da282d94f018e7e7c6781de Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:52:54 +1100 Subject: [PATCH 10/25] Stub authorization inside markdown and upload integration tests --- test/integration/spree/admin/markdown_integration_test.rb | 1 + test/integration/spree/admin/upload_integration_test.rb | 1 + 2 files changed, 2 insertions(+) diff --git a/test/integration/spree/admin/markdown_integration_test.rb b/test/integration/spree/admin/markdown_integration_test.rb index 9e2ffea..b78759b 100644 --- a/test/integration/spree/admin/markdown_integration_test.rb +++ b/test/integration/spree/admin/markdown_integration_test.rb @@ -4,6 +4,7 @@ class Spree::Admin::MarkdownIntegrationTest < SpreeEssentials::IntegrationCase setup do SpreeEssentials.register :example, SpreeEssentialExample + stub_authorization! end teardown do diff --git a/test/integration/spree/admin/upload_integration_test.rb b/test/integration/spree/admin/upload_integration_test.rb index 6517ca3..bd8bb53 100644 --- a/test/integration/spree/admin/upload_integration_test.rb +++ b/test/integration/spree/admin/upload_integration_test.rb @@ -6,6 +6,7 @@ def setup Spree::Upload.destroy_all @image = File.expand_path("../../../../support/files/1.png", __FILE__) @image2 = File.expand_path("../../../../support/files/2.png", __FILE__) + stub_authorization! end should "have a contents tab" do From 4e484cc975ec44fae864cda702a24056a4de7f5f Mon Sep 17 00:00:00 2001 From: Ryan Bigg Date: Wed, 24 Oct 2012 20:59:29 +1100 Subject: [PATCH 11/25] Correct tests in upload_integration_test --- test/integration/spree/admin/upload_integration_test.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/integration/spree/admin/upload_integration_test.rb b/test/integration/spree/admin/upload_integration_test.rb index bd8bb53..7c4f493 100644 --- a/test/integration/spree/admin/upload_integration_test.rb +++ b/test/integration/spree/admin/upload_integration_test.rb @@ -60,7 +60,7 @@ def setup assert_seen "Just an image!", :within => "tr#upload_#{@upload.id}" within "td.actions" do assert find("a.icon_link").native.attribute("href").include?(spree.edit_admin_upload_path(@upload)) - assert has_selector?("a[href='#']") + assert has_selector?("a.delete-resource") end end @@ -77,8 +77,9 @@ def setup should "destroy the upload" do visit spree.admin_uploads_path - find("a[href='#']").click - find_by_id("popup_ok").click + find("a.delete-resource").click + page.driver.browser.switch_to.alert.accept + assert_seen "Upload has been successfully removed!" end end From 82aad7606ba6bdbde823a43a2dfa5d6a7963058d Mon Sep 17 00:00:00 2001 From: Stephane Bounmy Date: Wed, 31 Oct 2012 08:50:27 +0100 Subject: [PATCH 12/25] spree 1-2-stable compliant however integration test fails --- spree_essentials.gemspec | 7 ++++--- test/dummy_hooks/before_migrate.rb | 5 +---- test/dummy_hooks/templates/spree_user_error_fix.rb | 3 --- 3 files changed, 5 insertions(+), 10 deletions(-) delete mode 100644 test/dummy_hooks/templates/spree_user_error_fix.rb diff --git a/spree_essentials.gemspec b/spree_essentials.gemspec index 68f6c01..e9f308f 100644 --- a/spree_essentials.gemspec +++ b/spree_essentials.gemspec @@ -15,18 +15,19 @@ Gem::Specification.new do |s| s.files = `git ls-files`.split("\n") s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") - + s.require_paths = ["lib"] - s.add_runtime_dependency('spree_core', '~> 1.1.0') + s.add_runtime_dependency('spree_core', '~> 1.2.0') s.add_runtime_dependency('rdiscount', '~> 1.6.8') s.add_development_dependency('shoulda', '~> 3.0.0') + s.add_development_dependency('shoulda-context', '1.0.0') s.add_development_dependency('dummier', '~> 0.3.0') s.add_development_dependency('factory_girl', '~> 2.6.0') s.add_development_dependency('capybara', '~> 1.1.2') s.add_development_dependency('sqlite3', '~> 1.3.4') s.add_development_dependency('simplecov', '~> 0.6.1') # s.add_development_dependency('turn', '~> 0.9.3') - + end diff --git a/test/dummy_hooks/before_migrate.rb b/test/dummy_hooks/before_migrate.rb index b1a3c33..596443e 100644 --- a/test/dummy_hooks/before_migrate.rb +++ b/test/dummy_hooks/before_migrate.rb @@ -10,10 +10,7 @@ " # Mount Spree's routes\n mount Spree::Core::Engine, :at => '/'\n" end -# Fix uninitialized constant Spree::User::DestroyWithOrdersError -template "spree_user_error_fix.rb", "config/initializers/spree_user_error_fix.rb" - -# remove all stylesheets except core +# remove all stylesheets except core %w(admin store).each do |ns| template "#{ns}/all.js", "app/assets/javascripts/#{ns}/all.js", :force => true template "#{ns}/all.css", "app/assets/stylesheets/#{ns}/all.css", :force => true diff --git a/test/dummy_hooks/templates/spree_user_error_fix.rb b/test/dummy_hooks/templates/spree_user_error_fix.rb deleted file mode 100644 index 86da9db..0000000 --- a/test/dummy_hooks/templates/spree_user_error_fix.rb +++ /dev/null @@ -1,3 +0,0 @@ -unless Spree::User.const_defined?(:DestroyWithOrdersError) - class Spree::User::DestroyWithOrdersError < StandardError; end -end From 711ea78197e91e498e0a19e93120ef5fbd2d1deb Mon Sep 17 00:00:00 2001 From: Stephane Bounmy Date: Wed, 31 Oct 2012 09:13:57 +0100 Subject: [PATCH 13/25] added legacy user initializer to dummy hook --- test/dummy_hooks/before_migrate.rb | 3 +++ test/dummy_hooks/templates/initializers/spree_user.rb | 1 + 2 files changed, 4 insertions(+) create mode 100644 test/dummy_hooks/templates/initializers/spree_user.rb diff --git a/test/dummy_hooks/before_migrate.rb b/test/dummy_hooks/before_migrate.rb index 596443e..43d927a 100644 --- a/test/dummy_hooks/before_migrate.rb +++ b/test/dummy_hooks/before_migrate.rb @@ -5,6 +5,9 @@ # Install spree's migrations rake "spree:install:migrations" +# Copy spree user initializer +template "initializers/spree_user.rb", "config/initializers/spree_user.rb" + # Mount the Spree::Core routes insert_into_file File.join('config', 'routes.rb'), :after => "Application.routes.draw do\n" do " # Mount Spree's routes\n mount Spree::Core::Engine, :at => '/'\n" diff --git a/test/dummy_hooks/templates/initializers/spree_user.rb b/test/dummy_hooks/templates/initializers/spree_user.rb new file mode 100644 index 0000000..4c478cd --- /dev/null +++ b/test/dummy_hooks/templates/initializers/spree_user.rb @@ -0,0 +1 @@ +Spree.user_class = "Spree::LegacyUser" \ No newline at end of file From b3a79535fe53584ea1cc94eef126b14ed57300d5 Mon Sep 17 00:00:00 2001 From: Stephane Bounmy Date: Wed, 19 Dec 2012 23:45:28 +0100 Subject: [PATCH 14/25] bump spree 1.3 --- spree_essentials.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spree_essentials.gemspec b/spree_essentials.gemspec index e9f308f..1daf30d 100644 --- a/spree_essentials.gemspec +++ b/spree_essentials.gemspec @@ -18,7 +18,7 @@ Gem::Specification.new do |s| s.require_paths = ["lib"] - s.add_runtime_dependency('spree_core', '~> 1.2.0') + s.add_runtime_dependency('spree_core', '~> 1.3.0') s.add_runtime_dependency('rdiscount', '~> 1.6.8') s.add_development_dependency('shoulda', '~> 3.0.0') From a05ca0d1a893a4835331df1d9ae0b29ff2ce05b0 Mon Sep 17 00:00:00 2001 From: Stephane Bounmy Date: Sat, 23 Feb 2013 01:55:42 +0100 Subject: [PATCH 15/25] fix : sorting with ransack and fully support spree 1.3 new admin --- .../spree/admin/uploads_controller.rb | 2 +- app/overrides/admin/spree_essentials.rb | 2 +- .../admin/shared/_contents_sub_menu.html.erb | 4 +- app/views/spree/admin/uploads/_form.html.erb | 23 ++++-- app/views/spree/admin/uploads/index.html.erb | 80 ++++++++++++------- app/views/spree/admin/uploads/new.html.erb | 6 +- 6 files changed, 71 insertions(+), 46 deletions(-) diff --git a/app/controllers/spree/admin/uploads_controller.rb b/app/controllers/spree/admin/uploads_controller.rb index 5797253..ce1ec0f 100644 --- a/app/controllers/spree/admin/uploads_controller.rb +++ b/app/controllers/spree/admin/uploads_controller.rb @@ -8,7 +8,7 @@ def index def collection params[:q] ||= {} - params[:q][:sort] ||= "created_at.desc" + params[:q][:sorts] ||= "attachment_updated_at desc" @search = Spree::Upload.search(params[:q]) if request.xhr? @collection = @search.result diff --git a/app/overrides/admin/spree_essentials.rb b/app/overrides/admin/spree_essentials.rb index 917fb24..a230cfe 100644 --- a/app/overrides/admin/spree_essentials.rb +++ b/app/overrides/admin/spree_essentials.rb @@ -8,6 +8,6 @@ # Adds the contents menu. Inside the contents sub menu we ensure it's needed Deface::Override.new(:virtual_path => "spree/layouts/admin", :name => "spree_essential_contents_menu", - :insert_top => "#sub-menu[data-hook]", + :insert_before => "code[erb-silent]:contains('content_for?(:sub_menu)')", :partial => "spree/admin/shared/contents_sub_menu", :disabled => false) diff --git a/app/views/spree/admin/shared/_contents_sub_menu.html.erb b/app/views/spree/admin/shared/_contents_sub_menu.html.erb index 2945da6..d9dd65f 100644 --- a/app/views/spree/admin/shared/_contents_sub_menu.html.erb +++ b/app/views/spree/admin/shared/_contents_sub_menu.html.erb @@ -1,10 +1,10 @@ <% if inside_contents_tab? %> <% content_for :sub_menu do %> -