Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a maximum lifetime for the session cookie #22

Open
jsf9k opened this issue Dec 17, 2020 · 0 comments
Open

Consider adding a maximum lifetime for the session cookie #22

jsf9k opened this issue Dec 17, 2020 · 0 comments
Labels
good first issue This issue or pull request is well-defined and good for newcomers improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@jsf9k
Copy link
Member

jsf9k commented Dec 17, 2020

🚀 Feature Proposal

The SessionMaxAge directive of Apache's mod_session module allows us to set a maximum age for an inactive browser session. The SessionMaxAge clock is reset every time the session is saved, so the session will not expire as long as the user keeps interacting with Guacamole. But if the user is inactive for SessionMaxAge seconds then the session is expired and the user must once again present valid Kerberos credentials to continue interacting with Guacamole. The default value (which we are currently using) is zero, which corresponds to no maximum age for sessions.

We should consider assigning a maximum session age of, say, one hour or one day.

Motivation

This came up because one of the assessors noticed that he was able to continue interacting with a Guacamole session after his Kerberos credentials expired. That was not surprising, since he presumably still had a valid session cookie, but in writing an email response to him I starting looking at the Apache documentation to determine what the maximum session age was currently set to.

@jsf9k jsf9k added good first issue This issue or pull request is well-defined and good for newcomers improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue or pull request is well-defined and good for newcomers improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

1 participant