Skip to content

Implement popup support for OSR #290

Open
@magreenblatt

Description

@magreenblatt

Original report by Joe Lauer (Bitbucket: jlauer, GitHub: jlauer).


Hey @magreenblatt,

In Java-Cef's onBeforePopup() method, the native code checks this first:

if (browser->GetHost()->IsWindowRenderingDisabled()) {
    // Cancel popups in off-screen rendering mode.
    return true;
}

Is there a reason why popups would be disabled if in OSR-mode? Happy to submit a PR fix if this is simply legacy/forgotten code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions