Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement popup support for OSR #290

Open
magreenblatt opened this issue Dec 13, 2017 · 2 comments
Open

Implement popup support for OSR #290

magreenblatt opened this issue Dec 13, 2017 · 2 comments
Labels
enhancement Enhancement request

Comments

@magreenblatt
Copy link
Collaborator

Original report by Joe Lauer (Bitbucket: jlauer, GitHub: jlauer).


Hey @magreenblatt,

In Java-Cef's onBeforePopup() method, the native code checks this first:

if (browser->GetHost()->IsWindowRenderingDisabled()) {
    // Cancel popups in off-screen rendering mode.
    return true;
}

Is there a reason why popups would be disabled if in OSR-mode? Happy to submit a PR fix if this is simply legacy/forgotten code.

@magreenblatt
Copy link
Collaborator Author

It just hasn't been implemented yet (creating a popup window that renders with OSR). A PR would be welcome, thanks :)

@magreenblatt
Copy link
Collaborator Author

  • changed title from "Popups Are Cancelled for Off Screen Rendered Windows" to "Implement popup support for OSR"
  • changed kind from "bug" to "enhancement"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant