Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion options CefLifeSpanHandler() #244

Open
magreenblatt opened this issue Nov 7, 2016 · 6 comments
Open

Expansion options CefLifeSpanHandler() #244

magreenblatt opened this issue Nov 7, 2016 · 6 comments
Labels
enhancement Enhancement request

Comments

@magreenblatt
Copy link
Collaborator

Original report by Igor_Zh (Bitbucket: Igor_Zh).


onBeforePopup() method JCEF contains three parameters, but for full control over the popup that is not enough
The CEF implementation of this method extended

#!c++

OnBeforePopup( CefRefPtr< CefBrowser > browser, CefRefPtr< CefFrame > frame, const CefString& target_url, const CefString& target_frame_name, CefLifeSpanHandler::WindowOpenDisposition target_disposition, bool user_gesture, const CefPopupFeatures& popupFeatures, CefWindowInfo& windowInfo, CefRefPtr< CefClient >& client, CefBrowserSettings& settings, bool* no_javascript_access );

I propose to increase the options in JCEF

@magreenblatt
Copy link
Collaborator Author

Original comment by Oliver Schemmel (Bitbucket: Oliver Schemmel).


Dear Marshall,

in order to control the creation of the popup window we need a solution to this issue as well. Is there any chance that this issue will be resolved anytime soon?

Best regards,

Oliver

@magreenblatt
Copy link
Collaborator Author

Original comment by Andrei Pivkine (Bitbucket: andreiPiv, GitHub: andreiPiv).


What extra options exactly are you requiring? or are you proposing the whole options are exposed? Looks like a signature change + applying it in JCEF native

@magreenblatt
Copy link
Collaborator Author

Original comment by Oliver Schemmel (Bitbucket: Oliver Schemmel).


It would be nice, to have all params from OnBeforePop exposed to the Java Wrapper.

We want to manipulate the look of the opened popup window. E.g. the icon, the tile bar text, window position, full screen mode etc. We understand that this could be done with CEF by changing properties of CefWindowInfo.

So we need at least this parameter in Java-CEF.

@magreenblatt
Copy link
Collaborator Author

  • removed "557058:2f2a2aee-b500-4023-9734-037e9897c3ab" assignee_account_id

@magreenblatt
Copy link
Collaborator Author

  • changed priority from "blocker" to "minor"

@magreenblatt
Copy link
Collaborator Author

Original comment by Frank Dekker (Bitbucket: Frank, GitHub: Frank).


(Partially) added in PR: pull request #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant