-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor java folder to follow Maven/Gradle convention #230
Comments
Why is this necessary? Is there some tooling you're trying to use that does not work with the current directory layout? |
Original comment by Paul Furbacher (Bitbucket: Paul Furbacher). It's not necessary, that's why I set the issue type to "proposal" and priority to "minor". Reasons:
I don't know, I've been doing Java development since 1997. I have found it's generally good to follow conventions. Most Java developers use the Maven/Gradle project structure, even when it includes building native libs, etc. And it's not that for example, Gradle won't work with this folder structure:
accommodates it. And there is a Java project convention around "tests". They are run in a test harness (e.g., JUnit, Selenium). What you present are examples, demos, uses. Hence the proposal to align the naming and project structure accordingly in this regard. Just suggestions; you can close this issue if you don't feel I've made a compelling enough case. |
Proposed PR here: https://bitbucket.org/chromiumembedded/java-cef/pull-requests/20 |
Maven build/config is now available at https://github.com/jcefmaven/jcefmaven |
Original report by Paul Furbacher (Bitbucket: Paul Furbacher).
There's a widely adopted, standard way of setting up Java source and test directories/folders, first specified by Maven and continued in Gradle.
java-cef doesn't honor this convention, but it there's no reason it shouldn't.
The current folder structure:
should be refactored to
In addition, the
tests
folder should be refactored toGiven the nature of the "tests" (they don't run in a test harness), I'd favor either "demos" or "examples".
The text was updated successfully, but these errors were encountered: