Improve server statistics retrieval

* Don't always force GC
* Cancel pending requests if the request is automatic (i.e. comes
  from a "server state changed" event).

Author: rpaquay

src/VsChromium/Features/IndexServerInfo/IShowServerInfoService.cs

@@ -7,11 +7,11 @@
 
 namespace VsChromium.Features.IndexServerInfo {
   public interface IShowServerInfoService {
-    void ShowServerStatusDialog();
+    void ShowServerStatusDialog(bool forceGarbageCollection);
     void ShowProjectIndexDetailsDialog(string path);
     void ShowDirectoryIndexDetailsDialog(string path);
 
-    void FetchDatabaseStatistics(bool forceGarbageCollect, Action<GetDatabaseStatisticsResponse> callback);
+    void FetchDatabaseStatistics(Action<GetDatabaseStatisticsResponse> callback);
 
     string GetIndexStatusText(GetDatabaseStatisticsResponse response);
     string GetIndexingServerStatusText(GetDatabaseStatisticsResponse response);

src/VsChromium/Features/IndexServerInfo/ShowServerInfoService.cs

@@ -28,7 +28,7 @@ public ShowServerInfoService(IDispatchThreadServerRequestExecutor dispatchThread
       _shellHost = shellHost;
     }
 
-    public void ShowServerStatusDialog() {
+    public void ShowServerStatusDialog(bool forceGarbageCollection) {
       var dialog = new ServerStatusDialog();
       dialog.HasMinimizeButton = false;
       dialog.HasMaximizeButton = false;
@@ -38,7 +38,7 @@ public void ShowServerStatusDialog() {
       var isClosed = false;
       dialog.Closed += (sender, args) => isClosed = true;
 
-      FetchDatabaseStatistics(true, response => {
+      FetchDatabaseStatisticsImpl(Guid.NewGuid().ToString(), TimeSpan.Zero, forceGarbageCollection, response => {
         if (isClosed) {
           return;
         }
@@ -69,11 +69,12 @@ public void ShowServerStatusDialog() {
         } else {
           message.AppendFormat("Last updated: {0}\r\n", "n/a (index is empty)");
         }
+
         dialog.ViewModel.IndexStatus = message.ToString().TrimSuffix("\r\n");
         message.Clear();
 
-        message.AppendFormat("Managed memory: {0:n2} MB\r\n", (double)response.ServerGcMemoryUsage / (1024 * 1024));
-        message.AppendFormat("Native memory: {0:n2} MB\r\n", (double)response.ServerNativeMemoryUsage / (1024 * 1024));
+        message.AppendFormat("Managed memory: {0:n2} MB\r\n", (double) response.ServerGcMemoryUsage / (1024 * 1024));
+        message.AppendFormat("Native memory: {0:n2} MB\r\n", (double) response.ServerNativeMemoryUsage / (1024 * 1024));
         dialog.ViewModel.MemoryStatus = message.ToString().TrimSuffix("\r\n");
       });
 
@@ -101,19 +102,19 @@ private void OnShowServerDetailsInvoked() {
             dialog.ViewModel.Waiting = false;
           },
           OnDispatchThreadSuccess = typedResponse => {
-            var response = (GetDatabaseDetailsResponse)typedResponse;
+            var response = (GetDatabaseDetailsResponse) typedResponse;
             var projectDetails = response.Projects.Select(x => new ProjectDetailsViewModel {
               ProjectDetails = x
             }).ToList();
             foreach (var x in projectDetails) {
-              x.ShowProjectConfigurationInvoked += (sender, args) => {
-                ShowProjectConfiguration(x);
-              };
+              x.ShowProjectConfigurationInvoked += (sender, args) => { ShowProjectConfiguration(x); };
             }
+
             dialog.ViewModel.Projects.AddRange(projectDetails);
             if (dialog.ViewModel.Projects.Count > 0) {
               dialog.ViewModel.SelectedProject = dialog.ViewModel.Projects[0];
             }
+
             dialog.ViewModel.Waiting = false;
           }
         });
@@ -147,7 +148,7 @@ public void ShowProjectIndexDetailsDialog(string path) {
           _shellHost.ShowErrorMessageBox("Error", error.Message);
         },
         OnDispatchThreadSuccess = typedResponse => {
-          var response = (GetProjectDetailsResponse)typedResponse;
+          var response = (GetProjectDetailsResponse) typedResponse;
           dialog.ViewModel.ProjectDetails = response.ProjectDetails;
           dialog.ViewModel.Waiting = false;
         },
@@ -179,7 +180,7 @@ public void ShowDirectoryIndexDetailsDialog(string path) {
           _shellHost.ShowErrorMessageBox("Error", error.Message);
         },
         OnDispatchThreadSuccess = typedResponse => {
-          var response1 = (GetDirectoryDetailsResponse)typedResponse;
+          var response1 = (GetDirectoryDetailsResponse) typedResponse;
           dialog.ViewModel.DirectoryDetails = response1.DirectoryDetails;
           dialog.ViewModel.Waiting = false;
         },
@@ -199,20 +200,12 @@ private void ShowProjectConfiguration(ProjectDetailsViewModel projectDetailsView
       dialog.ShowModal();
     }
 
-    public void FetchDatabaseStatistics(bool forceGarbageCollect, Action<GetDatabaseStatisticsResponse> callback) {
-      _dispatchThreadServerRequestExecutor.Post(
-        new DispatchThreadServerRequest {
-          Id = Guid.NewGuid().ToString(),
-          Request = new GetDatabaseStatisticsRequest { ForceGabageCollection = forceGarbageCollect },
-          OnDispatchThreadSuccess = typedResponse => {
-            var response = (GetDatabaseStatisticsResponse)typedResponse;
-            callback(response);
-          }
-        });
+    public void FetchDatabaseStatistics(Action<GetDatabaseStatisticsResponse> callback) {
+      FetchDatabaseStatisticsImpl(nameof(FetchDatabaseStatistics), null, false, callback);
     }
 
     public string GetIndexStatusText(GetDatabaseStatisticsResponse response) {
-      var memoryUsageMb = (double)response.ServerNativeMemoryUsage / 1024L / 1024L;
+      var memoryUsageMb = (double) response.ServerNativeMemoryUsage / 1024L / 1024L;
       var message = String.Format("Index: {0:n0} files - {1:n0} MB", response.SearchableFileCount, memoryUsageMb);
       return message;
     }
@@ -259,22 +252,47 @@ public string HumanReadableDuration(DateTime utcTime) {
       if (span.TotalSeconds <= 5) {
         return "a few seconds ago";
       }
+
       if (span.TotalSeconds <= 50) {
         return "less than 1 minute ago";
       }
+
       if (span.TotalMinutes <= 1) {
         return "about 1 minute ago";
       }
+
       if (span.TotalMinutes <= 60) {
         return string.Format("about {0:n0} minutes ago", Math.Ceiling(span.TotalMinutes));
       }
+
       if (span.TotalHours <= 1.5) {
         return "about one hour ago";
       }
+
       if (span.TotalHours <= 24) {
         return string.Format("about {0:n0} hours ago", Math.Ceiling(span.TotalHours));
       }
+
       return "more than one day ago";
     }
+
+    public void FetchDatabaseStatisticsImpl(string requestId, TimeSpan? delay, bool forceGarbageCollect,
+      Action<GetDatabaseStatisticsResponse> callback) {
+      var request = new DispatchThreadServerRequest {
+        Id = requestId,
+        Request = new GetDatabaseStatisticsRequest {
+          ForceGabageCollection = forceGarbageCollect
+        },
+        OnDispatchThreadSuccess = typedResponse => {
+          var response = (GetDatabaseStatisticsResponse) typedResponse;
+          callback(response);
+        }
+      };
+      if (delay != null) {
+        request.Delay = delay.Value;
+      }
+
+      _dispatchThreadServerRequestExecutor.Post(request);
+    }
   }
 }

src/VsChromium/Features/ToolWindows/CodeSearch/CodeSearchControl.xaml.cs

@@ -329,7 +329,8 @@ private void PauseResumeIndexingButton_Click(object sender, RoutedEventArgs e) {
     }
 
     private void ServerInfo_Click(object sender, RoutedEventArgs e) {
-      Logger.WrapActionInvocation(() => Controller.ShowServerInfo());
+      var forceGarbageCollection = Keyboard.Modifiers.HasFlag(ModifierKeys.Shift);
+      Logger.WrapActionInvocation(() => Controller.ShowServerInfo(forceGarbageCollection));
     }
   }
 }

src/VsChromium/Features/ToolWindows/CodeSearch/CodeSearchController.cs

@@ -221,8 +221,8 @@ public void CancelSearch() {
       ViewModel.SwitchToInformationMessages();
     }
 
-    public void ShowServerInfo() {
-      _showServerInfoService.ShowServerStatusDialog();
+    public void ShowServerInfo(bool forceGarbageCollection) {
+      _showServerInfoService.ShowServerStatusDialog(forceGarbageCollection);
     }
 
     public void RefreshFileSystemTree() {
@@ -701,7 +701,7 @@ private void SearchWorker(SearchWorkerParams workerParams) {
     }
 
     private void FetchDatabaseStatistics() {
-      _showServerInfoService.FetchDatabaseStatistics(false, UpdateIndexingServerToolbarStatus);
+      _showServerInfoService.FetchDatabaseStatistics(UpdateIndexingServerToolbarStatus);
     }
 
     private void UpdateIndexingServerToolbarStatus(GetDatabaseStatisticsResponse response) {

src/VsChromium/Features/ToolWindows/CodeSearch/ICodeSearchController.cs

@@ -25,7 +25,7 @@ public interface ICodeSearchController : IDisposable {
 
     void RefreshFileSystemTree();
     void PauseResumeIndexing();
-    void ShowServerInfo();
+    void ShowServerInfo(bool forceGarbageCollection);
 
     void PerformSearch(bool immediate);
     void QuickSearchCode(string searchPattern);