Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

where can I get the original version of the dom_distiller.js? #1

Open
yangxiaomin08 opened this issue Dec 22, 2016 · 11 comments
Open

Comments

@yangxiaomin08
Copy link

Hi,

I would like to read the code of the dom_distiller.js, but the version in git is hard to read? Where can I get the readable version of the js? thanks.

@wychen
Copy link
Contributor

wychen commented Dec 22, 2016

It's here: https://github.com/chromium/dom-distiller
I've updated the project description.

@yangxiaomin08
Copy link
Author

Thanks. what I mean is the javascript which used to distill the page but not the c++ code in chromium? I didn't find the javascript which is not minified

@wychen
Copy link
Contributor

wychen commented Dec 23, 2016

You'll need to build the JavaScript code from Java yourself. Search for "style PRETTY" in README here: https://github.com/chromium/dom-distiller/blob/master/README.md

Even when it is not minified, it'd still look like generated code. If you want to understand the algorithm, it's better to read the Java code.

@yangxiaomin08
Copy link
Author

yangxiaomin08 commented Dec 26, 2016

wychen, really appreciate for your quick help.
I will try that.

@yangxiaomin08
Copy link
Author

Hi wychen,

Is it possible that I debug directly in the java code rather than the javascript? What I mean is that if I have customized the distiller, I want to test it in java code firstly, and if it works, I will start to package it to javascript and integrate into dom_distiller component of chrome.

Here is another question, is there any document about the dom_distiller itself which I mean the java code but not the dom_distiller component in chrome.

@wychen
Copy link
Contributor

wychen commented Dec 26, 2016

You can debug in Chrome, and with source map, you can kind of debug in Java. Source map is currently broken, but can be temporarily fixed by locally reverting a CL. https://bugs.chromium.org/p/chromium/issues/detail?id=617360

There's no better document than the code itself now.

@yangxiaomin08
Copy link
Author

OK. I will try it later. thanks again.

Is there any group to discuss the dom_distiller?

@wychen
Copy link
Contributor

wychen commented Dec 26, 2016

Bugs and feature requests usually go to crbug.com. There's currently no specific place for free form discussion in public, but feel free to reach out. BTW, what do you want to do with DOM distiller?

@yangxiaomin08
Copy link
Author

I am trying to 'scratch' the website which is for desktop and convert to mobile-friendly website.

Can I contact you by your gmail address if I have some question about the dom_distiller? ~

@wychen
Copy link
Contributor

wychen commented Dec 27, 2016

Public discussions here can potentially help others as well. If you have private inquiries, feel free to reach me by email, but that would be of lower priority.

@yangxiaomin08
Copy link
Author

Yes, I agree. Let's choose public discussion as possible.

Just open an issue in dom_distill repo to start with it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants