Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Στυλιανός is transformed to Στυλιανό instead of Στυλιανέ #2

Open
chrispanag opened this issue Sep 13, 2018 · 4 comments
Assignees

Comments

@chrispanag
Copy link
Owner

The lib transforms all the names that end with -ός by removing the 'ς' (Νικολός -> Νικολό). 'Στυλιανός' is an exception to this rule and can't be modeled as a specific rule.

We'll need to create a way to support some exceptions to each rule, so that exceptions are scalable.

@pappasadrian
Copy link
Contributor

pappasadrian commented Jan 4, 2021

I'd say that "Νικολός" is probably the exception here.
See other -ός male names (for example, exhaustive list of names starting with A, taken from onomatologio.gr ):
Αγαπητός
Αδριανός
Αιμιλιανός
Ακριβός
Ασκληπιός
Αυγερινός

all these should be -έ

@chrispanag
Copy link
Owner Author

Good point, an exception list should be added nevertheless...

If there is enough interest for this package, I can resume development, maybe add some tests etc.

@chrispanag chrispanag self-assigned this Jan 4, 2021
@pappasadrian
Copy link
Contributor

hello, I just saw this repo being mentioned here https://www.facebook.com/pappasadrian/posts/738203123464595:26 and I thought I'd take a look. I'm actually adding some extra tests right now, that if I am guessing correctly, will fail with the current rules

@chrispanag
Copy link
Owner Author

open a PR and let's investigate what we can do to solve those problems... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants