Quick fix for set() method

Author: chrisboustead

index.html

@@ -13,26 +13,16 @@
   </video>
   <ul>
     <li><a href="test/">Run unit tests in browser.</a></li>
-    
+
   </ul>
-  
+
   <script src="node_modules/video.js/dist/video.js"></script>
   <script src="dist/videojs-social-share-overlay.js"></script>
   <script>
     (function(window, videojs) {
       var player = window.player = videojs('videojs-social-share-overlay-player');
-      player.socialShareOverlay({
-        url: 'https://google.com/extra-long-url-with/wrap-that-should-be-cut-off-by-elipsis/page-1',
-        image: 'http://lorempixel.com/g/800/800',
-        title: 'Shared Video Title',
-        description: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
-        platforms: ['twitter','facebook','email','link'],
-        emailBody: "Check this out on github.com:",
-        via: 'wwe'
-      });
+      player.socialShareOverlay();
       player.on('ended', function(){
-
-        console.log('firing');
         player.socialShareOverlay.set({
           url: 'https://google.com/2',
           image: 'http://lorempixel.com/g/800/800',

package.json

@@ -1,6 +1,6 @@
 {
   "name": "videojs-social-share-overlay",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "Social share overlay for videojs",
   "main": "dist/videojs-social-share-overlay.cjs.js",
   "module": "dist/videojs-social-share-overlay.es.js",

src/plugin.js

@@ -74,8 +74,14 @@ class SocialShareOverlayPlugin {
     const concreteButtonInstance = player.controlBar.addChild(this._socialShareButton, {componentClass: 'socialShare'}, placementIndex)
     concreteButtonInstance.addClass('vjs-social-share')
     concreteButtonInstance.addClass('vjs-icon-share')
-    concreteButtonInstance.removeClass('vjs-hidden')
+    if(!this.options.url) {
+      concreteButtonInstance.addClass('vjs-hidden')
+    }
 
+    if(!this.shareOverlayEl) {
+      this.createOverlayEl();
+    }
+    this.populateShareOverlay();
   };
 
   createOverlayEl () {
@@ -124,13 +130,17 @@ class SocialShareOverlayPlugin {
 
   set(config){
     this.options = config;
-    this.populateShareOverlay;
+    this.populateShareOverlay();
   }
 
   populateShareOverlay () {
     if(!this.shareOverlayEl) {
       return;
     }
+    if(!this.options.url) {
+      return this._socialShareButton.addClass('vjs-hidden');
+    }
+    this._socialShareButton.removeClass('vjs-hidden');
     const title = this.shareOverlayEl.querySelector('.vjs-share-overlay-title')
     const desc = this.shareOverlayEl.querySelector('.vjs-share-overlay-description')
     const link = this.shareOverlayEl.querySelector('.vjs-share-overlay-link')
@@ -152,10 +162,6 @@ class SocialShareOverlayPlugin {
   }
 
   showShareOverlay() {
-    if(!this.shareOverlayEl) {
-      this.createOverlayEl();
-    }
-    this.populateShareOverlay();
     this.onSharePausedState = this.player.paused();
     this.player.pause();
     this.player.addClass("vjs-social-share-overlay-open");
@@ -207,8 +213,7 @@ class SocialShareOverlayPlugin {
 
   attachClipboard (){
     if(typeof Clipboard !== 'undefined') {
-      let clip = new Clipboard('.vjs-share-overlay-button.copy-link');
-      console.log('attached', clip);
+      new Clipboard('.vjs-share-overlay-button.copy-link');
     }
   }
 
@@ -222,7 +227,7 @@ class SocialShareOverlayPlugin {
   }
 
 
-    getTwitterShareLink (title, url){
+  getTwitterShareLink (title, url){
 
     const link = 'https://twitter.com/intent/tweet?';