Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README doesn't work well with dark mode github #59

Open
dhalucario opened this issue Mar 28, 2022 · 4 comments
Open

README doesn't work well with dark mode github #59

dhalucario opened this issue Mar 28, 2022 · 4 comments

Comments

@dhalucario
Copy link

Bildschirmfoto 2022-03-28 um 10 50 05

@draeder
Copy link
Collaborator

draeder commented Apr 1, 2022

I added some images to the repo to support dark mode. I need to do some testing before updating the readme.

@draeder
Copy link
Collaborator

draeder commented Apr 1, 2022

Well, I can confirm the image looks good in dark mode, but with markup, the hash doesn't change which one is displayed. And with markdown, the image can't be centered. :(

image

@chr15m
Copy link
Owner

chr15m commented Apr 2, 2022

Could just add a white background to the image.

@dhalucario
Copy link
Author

I'd recommend going after Telegrams design recommendation for stickers and add a border:
image
image

Looks like before on white backgrounds and on dark backgrounds its clearly visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants