Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlBackend createTable blindly drops if table exists #21

Open
masinoa opened this issue May 7, 2013 · 2 comments
Open

SqlBackend createTable blindly drops if table exists #21

masinoa opened this issue May 7, 2013 · 2 comments
Assignees
Labels

Comments

@masinoa
Copy link
Contributor

masinoa commented May 7, 2013

SqlBackend the createTable method blindly drops the table if it already exists. Is this what we want? It could instead throw an exception or the method could return some kind of status object, e.g. Completed, Failed(withReason), etc. Then the caller method can decide if the table should be dropped if it exists. Of course, we can also add a "dropIfExists" arg to the createTable method for convenience.

@ghost ghost assigned mitalia May 7, 2013
@murphyke
Copy link
Member

FWIW, I agree that it would be better to have control over this situation.

@mitalia
Copy link
Contributor

mitalia commented Jun 27, 2014

@murphyke this is going to go away in a future release. The upcoming release candidate adds logging support and includes a warning about this behavior when it's triggered:

https://github.com/cbmi/dataexpress/blob/develop/src/main/scala/edu/chop/cbmi/dataExpress/backends/SqlBackend.scala#L404-L418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants