Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Can the table cut from markdown be kept intact? #182

Open
2 tasks
gdw439 opened this issue Feb 27, 2025 · 1 comment
Open
2 tasks

[FEAT] Can the table cut from markdown be kept intact? #182

gdw439 opened this issue Feb 27, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gdw439
Copy link

gdw439 commented Feb 27, 2025

๐Ÿ“‹ Quick Check

  • I've checked this feature isn't already implemented or proposed
  • This feature is relevant to Chonkie's purpose (text chunking for RAG)

๐Ÿ’ก Feature Description

๐Ÿ› ๏ธ Implementation Approach

# Example of how this feature might work
from chonkie import ...

# Your implementation idea

๐ŸŽฏ Why is this needed?

@gdw439 gdw439 added the enhancement New feature or request label Feb 27, 2025
@bhavnicksm
Copy link
Collaborator

Hola @gdw439! ๐Ÿ‘‹

To translate your enhancement title,

Can the table cut from markdown be kept intact?

That's a good point. Currently, it is not supported in Chonkie, but mostly because we haven't yet been asked to do this. We know a good way to do this. Do you think this would be useful for you?

A proposed solution we thought of this was,

Make a non-divisible chunk class TableChunk which would keep the header and table rows separate, and each chunker would ensure that the header remains intact while only the rows are chunked up.

Since this is not on our current roadmap, we will keep this issue, and if enough people wish for this, we will add it to the next quarter's roadmap as a priority feature to support! ๐Ÿ˜„

Also, if someone wishes to create a PR for this, happy to support them~

Thanks ๐Ÿ˜Š

@bhavnicksm bhavnicksm changed the title [FEAT] ๅˆ‡ๅ‰ฒ markdwon ็š„่กจๆ ผ่ƒฝๅฎŒๆ•ดไฟ็•™ๅ— [FEAT] Can the table cut from markdown be kept intact? Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants