Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

configs for ogg or mp3 instead of flac #1

Open
jmtd opened this issue Aug 16, 2016 · 3 comments
Open

configs for ogg or mp3 instead of flac #1

jmtd opened this issue Aug 16, 2016 · 3 comments

Comments

@jmtd
Copy link

jmtd commented Aug 16, 2016

... would be nice

@fragglet
Copy link
Member

Worth remembering that these are example configs. I'm hoping we can get music pack authors to include config files with their packs (we have tentative approval for this from MusicallyInspired already). Normal users shouldn't need to mess around with these files for the most part.

However, you do have a point. One idea I had was to introduce an extra syntax meaning "any supported extension here" so that we make the code check for all the different extensions, rather than hard-coding one.

Note that we're only supporting .ogg and .flac since .mp3 doesn't support loop point metadata.

@chungy
Copy link

chungy commented Aug 17, 2016

MP3 is also a non-free format (albeit not for much longer, seems the patents expire next year), on top of severe quality issues compared to Vorbis...

@jmtd
Copy link
Author

jmtd commented Aug 17, 2016

MP3 is also a non-free format (albeit not for much longer, seems the patents expire next year), on top of severe quality issues compared to Vorbis...

Meh. I don't buy the quality issue, personally, with a modern MP3 encoder. And the ogg container is severely limited (base64 encoded album art? lol)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants