Fix lint warnings / comments.

Author: brocaar

internal/backend/basicstation/backend.go

@@ -193,18 +193,22 @@ func NewBackend(conf config.Config) (*Backend, error) {
 	return &b, nil
 }
 
+// GetDownlinkTXAckChan returns the channel for downlink tx acknowledgements.
 func (b *Backend) GetDownlinkTXAckChan() chan gw.DownlinkTXAck {
 	return b.downlinkTXAckChan
 }
 
+// GetGatewayStatsChan returns the channel for gateway statistics.
 func (b *Backend) GetGatewayStatsChan() chan gw.GatewayStats {
 	return b.gatewayStatsChan
 }
 
+// GetUplinkFrameChan returns the channel for received uplinks.
 func (b *Backend) GetUplinkFrameChan() chan gw.UplinkFrame {
 	return b.uplinkFrameChan
 }
 
+// GetSubscribeEventChan returns the channel for the (un)subscribe events.
 func (b *Backend) GetSubscribeEventChan() chan events.Subscribe {
 	return b.gateways.subscribeEventChan
 }
@@ -214,6 +218,7 @@ func (b *Backend) GetRawPacketForwarderEventChan() chan gw.RawPacketForwarderEve
 	return b.rawPacketForwarderEventChan
 }
 
+// SendDownlinkFrame sends the given downlink frame.
 func (b *Backend) SendDownlinkFrame(df gw.DownlinkFrame) error {
 	b.Lock()
 	defer b.Unlock()
@@ -254,6 +259,7 @@ func (b *Backend) SendDownlinkFrame(df gw.DownlinkFrame) error {
 	return nil
 }
 
+// ApplyConfiguration applies the given configuration to the gateway.
 func (b *Backend) ApplyConfiguration(gwConfig gw.GatewayConfiguration) error {
 	rc, err := structs.GetRouterConfigOld(b.region, b.netIDs, b.joinEUIs, b.frequencyMin, b.frequencyMax, gwConfig)
 	if err != nil {

internal/backend/basicstation/structs/downlink_message.go

@@ -14,7 +14,7 @@ import (
 	"github.com/brocaar/lorawan/band"
 )
 
-// DownlinkMessage implements the downlink message.
+// DownlinkFrame implements the downlink message.
 type DownlinkFrame struct {
 	MessageType MessageType `json:"msgtype"`
 

internal/backend/basicstation/structs/radio_meta_data.go

@@ -29,6 +29,7 @@ type RadioMetaDataUpInfo struct {
 	SNR     float32 `json:"snr"`
 }
 
+// SetRadioMetaDataToProto sets the given parameters to the given protobuf struct.
 func SetRadioMetaDataToProto(loraBand band.Band, gatewayID lorawan.EUI64, rmd RadioMetaData, pb *gw.UplinkFrame) error {
 	//
 	// TxInfo

internal/backend/concentratord/concentratord.go

@@ -91,27 +91,33 @@ func (b *Backend) getGatewayID() (lorawan.EUI64, error) {
 	return gatewayID, nil
 }
 
+// Close closes the backend.
 func (b *Backend) Close() error {
 	b.eventSock.Close()
 	return nil
 }
 
+// GetDownlinkTXAckChan returns the channel for downlink tx acknowledgements.
 func (b *Backend) GetDownlinkTXAckChan() chan gw.DownlinkTXAck {
 	return b.downlinkTXAckChan
 }
 
+// GetGatewayStatsChan returns the channel for gateway statistics.
 func (b *Backend) GetGatewayStatsChan() chan gw.GatewayStats {
 	return b.gatewayStatsChan
 }
 
+// GetUplinkFrameChan returns the channel for received uplinks.
 func (b *Backend) GetUplinkFrameChan() chan gw.UplinkFrame {
 	return b.uplinkFrameChan
 }
 
+// GetSubscribeEventChan returns the channel for the (un)subscribe events.
 func (b *Backend) GetSubscribeEventChan() chan events.Subscribe {
 	return b.subscribeEventChan
 }
 
+// SendDownlinkFrame sends the given downlink frame.
 func (b *Backend) SendDownlinkFrame(pl gw.DownlinkFrame) error {
 	loRaModInfo := pl.GetTxInfo().GetLoraModulationInfo()
 	if loRaModInfo != nil {
@@ -130,7 +136,7 @@ func (b *Backend) SendDownlinkFrame(pl gw.DownlinkFrame) error {
 		log.WithError(err).Fatal("backend/concentratord: send downlink command error")
 	}
 	if len(bb) == 0 {
-		return errors.New("no reply receieved, check concentratord logs for error!")
+		return errors.New("no reply receieved, check concentratord logs for error")
 	}
 
 	var ack gw.DownlinkTXAck
@@ -143,14 +149,17 @@ func (b *Backend) SendDownlinkFrame(pl gw.DownlinkFrame) error {
 	return nil
 }
 
+// ApplyConfiguration is not implemented.
 func (b *Backend) ApplyConfiguration(gw.GatewayConfiguration) error {
 	return nil
 }
 
+// GetRawPacketForwarderEventChan returns nil.
 func (b *Backend) GetRawPacketForwarderEventChan() chan gw.RawPacketForwarderEvent {
 	return nil
 }
 
+// RawPacketForwarderCommand is not implemented.
 func (b *Backend) RawPacketForwarderCommand(gw.RawPacketForwarderCommand) error {
 	return nil
 }

internal/commands/commands.go

@@ -13,9 +13,9 @@ import (
 	"github.com/pkg/errors"
 	log "github.com/sirupsen/logrus"
 
+	"github.com/brocaar/chirpstack-api/go/v3/gw"
 	"github.com/brocaar/chirpstack-gateway-bridge/internal/config"
 	"github.com/brocaar/chirpstack-gateway-bridge/internal/integration"
-	"github.com/brocaar/chirpstack-api/go/v3/gw"
 	"github.com/brocaar/lorawan"
 )
 
@@ -158,6 +158,7 @@ func execute(command string, stdin []byte, environment map[string]string) ([]byt
 	return stdoutB, stderrB, nil
 }
 
+// ParseCommandLine parses the given command to commands and arguments.
 // source: https://stackoverflow.com/questions/34118732/parse-a-command-line-string-into-flags-and-arguments-in-golang
 func ParseCommandLine(command string) ([]string, error) {
 	var args []string

internal/filters/filters.go

@@ -13,6 +13,7 @@ import (
 var netIDs []lorawan.NetID
 var joinEUIs [][2]lorawan.EUI64
 
+// Setup configures the filters package.
 func Setup(conf config.Config) error {
 	for _, netIDStr := range conf.Filters.NetIDs {
 		var netID lorawan.NetID

internal/forwarder/forwarder.go

@@ -15,6 +15,7 @@ import (
 
 var alwaysSubscribe []lorawan.EUI64
 
+// Setup configures the forwarder.
 func Setup(conf config.Config) error {
 	b := backend.GetBackend()
 	i := integration.GetIntegration()

internal/integration/integration.go

@@ -21,6 +21,7 @@ const (
 
 var integration Integration
 
+// Setup configures the integration.
 func Setup(conf config.Config) error {
 	var err error
 	integration, err = mqtt.NewBackend(conf)
@@ -36,6 +37,7 @@ func GetIntegration() Integration {
 	return integration
 }
 
+// Integration defines the interface that an integration must implement.
 type Integration interface {
 	// SetGatewaySubscription updates the gateway subscription for the given
 	// gateway ID. The integration must implement this such that it is safe

internal/integration/mqtt/backend.go

@@ -160,7 +160,7 @@ func (b *Backend) GetGatewayConfigurationChan() chan gw.GatewayConfiguration {
 	return b.gatewayConfigurationChan
 }
 
-// GetGatewayCommandExecRequestChan() returns the channel for gateway command execution.
+// GetGatewayCommandExecRequestChan returns the channel for gateway command execution.
 func (b *Backend) GetGatewayCommandExecRequestChan() chan gw.GatewayCommandExecRequest {
 	return b.gatewayCommandExecRequestChan
 }
@@ -170,6 +170,7 @@ func (b *Backend) GetRawPacketForwarderChan() chan gw.RawPacketForwarderCommand
 	return b.rawPacketForwarderCommandChan
 }
 
+// SetGatewaySubscription (un)subscribes the given gateway.
 func (b *Backend) SetGatewaySubscription(subscribe bool, gatewayID lorawan.EUI64) error {
 	b.Lock()
 	defer b.Unlock()

internal/metrics/metrics.go

@@ -9,6 +9,7 @@ import (
 	"github.com/brocaar/chirpstack-gateway-bridge/internal/config"
 )
 
+// Setup configures the metrics package.
 func Setup(conf config.Config) error {
 	if !conf.Metrics.Prometheus.EndpointEnabled {
 		return nil