Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord Id not showing up in the directory #202

Closed
cherylli opened this issue Aug 22, 2024 · 4 comments · Fixed by #252
Closed

Discord Id not showing up in the directory #202

cherylli opened this issue Aug 22, 2024 · 4 comments · Fixed by #252
Assignees
Labels
bug Something isn't working status/IN PROGRESS team/BE Backend Team team/FE Frontend Team

Comments

@cherylli
Copy link

Describe the bug
Discord id not showing up in the directory

To Reproduce Bug
Steps to reproduce the bug:

  1. Go to My Voyage
  2. Go to directory

Expected behavior
It should show up if they have their discord account connected via oauth. currently they don't so the display is correct. However, we will need to fix the backend to return users discord id in the team info endpoint (it is now stored in another table - userOAuthProfile)

Screenshots
image

Additional context
Add any other context about the problem here.

--------------- End of User Report: DO NOT MODIFY ITEMS BELOW THIS LINE ---------------

GitHub Issue No. / ID

Team Task
Here will be added Team declaration by Team Leads.

Development start date
Date when dev team start fixing a bug

Development end date
Date when dev team complete fixing a bug

BugFix Deploy Date
Date when BugFix is deployed, and Bug Issue is closed

PO Comment
Here will be PO team add a comment.

@cherylli cherylli added bug Something isn't working team/BE Backend Team labels Aug 22, 2024
@jdmedlock jdmedlock added Add to Clickup Clone this issue to Clickup and removed Add to Clickup Clone this issue to Clickup labels Aug 23, 2024
@cherylli
Copy link
Author

So I realized we have already updated the api response last week - but I'll need to also update the swagger sample response

this is how it looks like now, so frontend needs to update how it gets the discordID from the response. I will seed the dev database to populate jessica's discord oauth
image

@cherylli cherylli added the team/FE Frontend Team label Aug 24, 2024
@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Aug 24, 2024

I'm guessing we use the providerUsername?

I didn't look at Swagger yet, I'm sure that will answer my question lol

@cherylli
Copy link
Author

cherylli commented Aug 25, 2024

yeah it would be something like oauthProfile.find(provider.name==="discord").providerUsername

@jdmedlock
Copy link
Contributor

jdmedlock commented Aug 28, 2024

DO NOT MODIFY/DELETE THIS COMMENT
Project task ID: 86b1v4mjw

@JaneMoroz JaneMoroz self-assigned this Sep 8, 2024
@JaneMoroz JaneMoroz mentioned this issue Sep 8, 2024
12 tasks
@JaneMoroz JaneMoroz linked a pull request Sep 8, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status/IN PROGRESS team/BE Backend Team team/FE Frontend Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants