phpstan baseline

Author: codemasher

.gitattributes

@@ -1,19 +1,20 @@
-/.build            export-ignore
-/.github           export-ignore
-/.idea             export-ignore
-/.phan             export-ignore
-/.phpdoc           export-ignore
-/docs              export-ignore
-/examples          export-ignore
-/tests             export-ignore
-/.editorconfig     export-ignore
-/.gitattributes    export-ignore
-/.gitignore        export-ignore
-/.readthedocs.yml  export-ignore
-/phpcs.xml.dist    export-ignore
-/phpdoc.xml.dist   export-ignore
-/phpmd.xml.dist    export-ignore
-/phpunit.xml.dist  export-ignore
-/phpstan.dist.neon export-ignore
+/.build                 export-ignore
+/.github                export-ignore
+/.idea                  export-ignore
+/.phan                  export-ignore
+/.phpdoc                export-ignore
+/docs                   export-ignore
+/examples               export-ignore
+/tests                  export-ignore
+/.editorconfig          export-ignore
+/.gitattributes         export-ignore
+/.gitignore             export-ignore
+/.readthedocs.yml       export-ignore
+/phpcs.xml.dist         export-ignore
+/phpdoc.xml.dist        export-ignore
+/phpmd.xml.dist         export-ignore
+/phpunit.xml.dist       export-ignore
+/phpstan.dist.neon      export-ignore
+/phpstan-baseline.neon  export-ignore
 
 *.php diff=php

phpstan-baseline.neon

@@ -0,0 +1,31 @@
+parameters:
+	ignoreErrors:
+		-
+			message: "#^Access to an undefined property chillerlan\\\\SettingsTest\\\\TestContainer\\:\\:\\$foo\\.$#"
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			message: "#^Access to private property chillerlan\\\\SettingsTest\\\\TestContainer\\:\\:\\$test3\\.$#"
+			count: 4
+			path: tests/ContainerTest.php
+
+		-
+			message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertFalse\\(\\) with true will always evaluate to false\\.$#"
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertNull\\(\\) with string will always evaluate to false\\.$#"
+			count: 2
+			path: tests/ContainerTest.php
+
+		-
+			message: "#^Property chillerlan\\\\SettingsTest\\\\TestContainer\\:\\:\\$test3 \\(string\\) in isset\\(\\) is not nullable\\.$#"
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			message: "#^Property chillerlan\\\\SettingsTest\\\\TestContainer\\:\\:\\$test3 is never read, only written\\.$#"
+			count: 1
+			path: tests/TestContainer.php

phpstan.dist.neon

@@ -8,6 +8,9 @@ parameters:
 		- src
 		- tests
 
+	treatPhpDocTypesAsCertain: false
+
 includes:
+	- phpstan-baseline.neon
 	- vendor/phpstan/phpstan/conf/bleedingEdge.neon
 	- vendor/phpstan/phpstan-deprecation-rules/rules.neon

tests/ContainerTest.php

@@ -27,7 +27,6 @@ public function testConstruct():void{
 
 		$this::assertSame('test1', $container->test1);
 		$this::assertSame(true, $container->test2);
-		/** @phpstan-ignore-next-line */
 		$this::assertNull($container->test3);
 		$this::assertSame('test4', $container->test4);
 
@@ -39,16 +38,13 @@ public function testGet():void{
 
 		$this::assertSame('foo', $container->test1);
 		$this::assertNull($container->test2);
-		/** @phpstan-ignore-next-line */
 		$this::assertNull($container->test3);
 		$this::assertNull($container->test4);
-		/** @phpstan-ignore-next-line */
 		$this::assertNull($container->foo);
 
 		// isset test
 		$this::assertTrue(isset($container->test1));
 		$this::assertFalse(isset($container->test2));
-		/** @phpstan-ignore-next-line */
 		$this::assertFalse(isset($container->test3));
 		$this::assertFalse(isset($container->test4));
 		$this::assertFalse(isset($container->foo));
@@ -66,12 +62,10 @@ public function testSet():void{
 		$container = new TestContainer;
 		$container->test1 = 'bar';
 		$container->test2 = false;
-		/** @phpstan-ignore-next-line */
 		$container->test3 = 'nope';
 
 		$this::assertSame('bar', $container->test1);
 		$this::assertSame(false, $container->test2);
-		/** @phpstan-ignore-next-line */
 		$this::assertNull($container->test3);
 
 		// unset

tests/TestContainer.php

@@ -16,6 +16,5 @@
 class TestContainer extends SettingsContainerAbstract{
 	use TestOptionsTrait;
 
-	/** @phpstan-ignore-next-line */
 	private string $test3 = 'what';
 }