🚿

codemasher · codemasher · commit ae0f31241554 · 2023-03-22T21:24:54.000+01:00
diff --git a/src/Data/QRDataModeInterface.php b/src/Data/QRDataModeInterface.php
@@ -21,10 +21,13 @@ interface QRDataModeInterface{
 	 * the current data mode: Number, Alphanum, Kanji, Hanzi, Byte, ECI
 	 *
 	 * tbh I hate this constant here, but it's part of the interface, so I can't just declare it in the abstract class.
-	 * phan will complain about a PhanAccessOverridesFinalConstant.
+	 * (phan will complain about a PhanAccessOverridesFinalConstant)
+	 *
+	 * @see https://wiki.php.net/rfc/final_class_const
 	 *
 	 * @var int
 	 * @see \chillerlan\QRCode\Common\Mode
+	 * @internal do not call this constant from the interface, but rather from one of the child classes
 	 */
 	public const DATAMODE = -1;
 
diff --git a/src/Output/QRMarkupHTML.php b/src/Output/QRMarkupHTML.php
@@ -42,7 +42,7 @@ protected function createMarkup(bool $saveToFile):string{
 		// wrap the snippet into a body when saving to file
 		if($saveToFile){
 			$html = sprintf(
-				'<!DOCTYPE html><html><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',
+				'<!DOCTYPE html><html lang=""><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',
 				$this->options->eol.$html
 			);
 		}

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,13 @@ interface QRDataModeInterface{`
`21`	`21`	`* the current data mode: Number, Alphanum, Kanji, Hanzi, Byte, ECI`
`22`	`22`	`*`
`23`	`23`	`* tbh I hate this constant here, but it's part of the interface, so I can't just declare it in the abstract class.`
`24`		`- * phan will complain about a PhanAccessOverridesFinalConstant.`
	`24`	`+ * (phan will complain about a PhanAccessOverridesFinalConstant)`
	`25`	`+ *`
	`26`	`+ * @see https://wiki.php.net/rfc/final_class_const`
`25`	`27`	`*`
`26`	`28`	`* @var int`
`27`	`29`	`* @see \chillerlan\QRCode\Common\Mode`
	`30`	`+ * @internal do not call this constant from the interface, but rather from one of the child classes`
`28`	`31`	`*/`
`29`	`32`	`public const DATAMODE = -1;`
`30`	`33`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected function createMarkup(bool $saveToFile):string{`
`42`	`42`	`// wrap the snippet into a body when saving to file`
`43`	`43`	`if($saveToFile){`
`44`	`44`	`$html = sprintf(`
`45`		`- '<!DOCTYPE html><html><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',`
	`45`	`+ '<!DOCTYPE html><html lang=""><head><meta charset="UTF-8"><title>QR Code</title></head><body>%s</body></html>',`
`46`	`46`	`$this->options->eol.$html`
`47`	`47`	`);`
`48`	`48`	`}`