From 6651bcd8d6708d7e13698babd6c1039f7bd752b7 Mon Sep 17 00:00:00 2001 From: Lukas Vonlanthen <1290802+lvonlanthen@users.noreply.github.com> Date: Fri, 24 Jun 2022 23:33:19 +0200 Subject: [PATCH] Increase meaningfulness of tests. Use different top and left starting positions and move by different X and Y values for more meaningful assertions. --- src/examples/Move.vue | 4 ++-- src/examples/MoveOnMouseUp.vue | 4 ++-- tests/specs/move.cy.js | 24 ++++++++++++------------ 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/examples/Move.vue b/src/examples/Move.vue index 04e543d..ed70656 100644 --- a/src/examples/Move.vue +++ b/src/examples/Move.vue @@ -56,8 +56,8 @@ export default { .absolute { position: absolute; margin: 0; - top: 100px; - left: 100px; + top: 10px; + left: 20px; width: 1000px; height: 1000px; } diff --git a/src/examples/MoveOnMouseUp.vue b/src/examples/MoveOnMouseUp.vue index 48cb458..25ff77c 100644 --- a/src/examples/MoveOnMouseUp.vue +++ b/src/examples/MoveOnMouseUp.vue @@ -53,8 +53,8 @@ export default { .absolute { position: absolute; margin: 0; - top: 100px; - left: 100px; + top: 10px; + left: 20px; width: 1000px; height: 1000px; } diff --git a/tests/specs/move.cy.js b/tests/specs/move.cy.js index 62a1d4e..7a4ec31 100644 --- a/tests/specs/move.cy.js +++ b/tests/specs/move.cy.js @@ -6,17 +6,17 @@ describe('Drag drop', () => { cy.findByTestId('draggable').should((target) => { const { top, left } = target.offset() - expect(top).to.be.equal(100) - expect(left).to.be.equal(100) + expect(top).to.be.equal(10) + expect(left).to.be.equal(20) }) - cy.findByTestId('draggable').move({ deltaX: 100, deltaY: 100 }) + cy.findByTestId('draggable').move({ deltaX: 30, deltaY: 40 }) - cy.findByTestId('draggable').should('have.css', 'transform', 'matrix(1, 0, 0, 1, 100, 100)') + cy.findByTestId('draggable').should('have.css', 'transform', 'matrix(1, 0, 0, 1, 30, 40)') cy.findByTestId('draggable').should((target) => { const { top, left } = target.offset() - expect(top).to.be.equal(200) - expect(left).to.be.equal(200) + expect(top).to.be.equal(50) + expect(left).to.be.equal(50) }) }) @@ -27,17 +27,17 @@ describe('Drag drop', () => { cy.findByTestId('draggable').should((target) => { const { top, left } = target.offset() - expect(top).to.be.equal(100) - expect(left).to.be.equal(100) + expect(top).to.be.equal(10) + expect(left).to.be.equal(20) }) - cy.findByTestId('draggable').move({ deltaX: 100, deltaY: 100 }) + cy.findByTestId('draggable').move({ deltaX: 30, deltaY: 40 }) - cy.findByTestId('draggable').should('have.css', 'transform', 'matrix(1, 0, 0, 1, 100, 100)') + cy.findByTestId('draggable').should('have.css', 'transform', 'matrix(1, 0, 0, 1, 30, 40)') cy.findByTestId('draggable').should((target) => { const { top, left } = target.offset() - expect(top).to.be.equal(200) - expect(left).to.be.equal(200) + expect(top).to.be.equal(50) + expect(left).to.be.equal(50) }) }) })